From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Cc: linux-mips@linux-mips.org, linux-ide@vger.kernel.org,
bzolnier@gmail.com, ralf@linux-mips.org
Subject: Re: [PATCH] TXx9: Add TX4938 ATA support
Date: Mon, 20 Oct 2008 18:40:56 +0400 [thread overview]
Message-ID: <48FC9878.4030306@ru.mvista.com> (raw)
In-Reply-To: <20081020.231450.51866269.anemo@mba.ocn.ne.jp>
Hello.
Atsushi Nemoto wrote:
>>>+ struct tx4938ide_platform_info pdata = {
>>>+ .ioport_shift = shift,
>>>+ .gbus_clock = tune ? txx9_gbus_clock : 0,
>> Any reason not to supply the GBUS clock?
> The EBUS channel might be used for both ATA and ISA or other local bus
> devices. In that case, the board setup code should initialize best
> timings for all devices and the IDE driver should not overrite it.
Ah, I forgot about the ATA address space being appeandage to ISA address
space on TX4939...
>> I'm afraid you can't just early return from the set_pio_mode() method...
> Do you mean I should use IDE_HFLAG_NO_SET_MODE instead of just
> returning from set_pio_mode?
No, that's for the smart RAID controllers that program the transfer modes
themselves. In your case, hwif->port_ops->set_pio_mode() must be NULL -- if
you're not going to allow the mode programming, that is.
MBR, Sergei
next prev parent reply other threads:[~2008-10-20 14:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-17 14:10 [PATCH] TXx9: Add TX4938 ATA support Atsushi Nemoto
2008-10-19 18:34 ` Sergei Shtylyov
2008-10-20 14:14 ` Atsushi Nemoto
2008-10-20 14:40 ` Sergei Shtylyov [this message]
2008-10-20 15:08 ` Atsushi Nemoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48FC9878.4030306@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=anemo@mba.ocn.ne.jp \
--cc=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox