From: Martin Gebert <martin.gebert@alpha-bit.de>
To: linux-mips@linux-mips.org
Subject: AU1000: SSI0 naming inconsistency
Date: Thu, 06 Nov 2008 12:06:15 +0100 [thread overview]
Message-ID: <4912CFA7.9000508@alpha-bit.de> (raw)
Hi!
Working on a 2.6.22 kernel for a AU1100 board, I came across the
following inconsistency in register naming in
include/asm/mach-au1x00/au1000.h, which still exists in 2.6.27.4 (lines
1334-1389). There's no register SSI0_CONTROL, it should be named
SSI0_ENABLE, as it is for SSI1:
--8><--
#define SSI0_CONTROL 0xB1600100
#define SSI_CONTROL_CD (1<<1)
#define SSI_CONTROL_E (1<<0)
/* SSI1 */
[...]
#define SSI1_ENABLE 0xB1680100
[...]
#define SSI_ENABLE_CD (1<<1)
#define SSI_ENABLE_E (1<<0)
--><8--
As I'm not working on a current kernel repo I don't dare to provide a
patch. Would fixing this be desirable?
Martin
next reply other threads:[~2008-11-06 11:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-06 11:06 Martin Gebert [this message]
2008-11-06 22:50 ` AU1000: SSI0 naming inconsistency Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4912CFA7.9000508@alpha-bit.de \
--to=martin.gebert@alpha-bit.de \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox