From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Wed, 12 Nov 2008 10:38:44 +0000 (GMT) Received: from h155.mvista.com ([63.81.120.155]:1484 "EHLO imap.sh.mvista.com") by ftp.linux-mips.org with ESMTP id S23630820AbYKLKii (ORCPT ); Wed, 12 Nov 2008 10:38:38 +0000 Received: from [127.0.0.1] (unknown [10.150.0.9]) by imap.sh.mvista.com (Postfix) with ESMTP id 613B93EC9; Wed, 12 Nov 2008 02:38:34 -0800 (PST) Message-ID: <491AB225.1010005@ru.mvista.com> Date: Wed, 12 Nov 2008 13:38:29 +0300 From: Sergei Shtylyov User-Agent: Thunderbird 2.0.0.17 (Windows/20080914) MIME-Version: 1.0 To: Manuel Lauss Cc: Kevin Hickey , Linux-MIPS , Florian Fainelli , Bruno Randolf Subject: Re: [PATCH 2/3] Alchemy: Move evalboard code to common directory References: <0b1dcd4090411d59e2272ca94da0fb4f5a4bbceb.1226143942.git.mano@roarinelk.homelinux.net> <1226462433.9026.12.camel@kh-d820-ubuntu.razamicroelectronics.com> <20081112060630.GB9358@roarinelk.homelinux.net> In-Reply-To: <20081112060630.GB9358@roarinelk.homelinux.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 21265 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: sshtylyov@ru.mvista.com Precedence: bulk X-list: linux-mips Hello. Manuel Lauss wrote: >> And in keeping with my other email, I think that the evalboards >> directory is a good idea (though I would recommend the name >> "develboards" as that is what DB stands for), but it should contain >> subdirectories for each board and a common directory for common DB code. >> Smashing all of the board code into one file doesn't leave any room to >> grow if that file gets too big. Also, a single common.c will not be >> sufficient in the future. >> > > Okay, I'll change that, test and resend. > > Thanks, > Manuel Lauss > [...] >>> Move all code of the Pb/Db boards to a single subdirectory and extract >>> some common code. >>> >>> Signed-off-by: Manuel Lauss >>> I see you, Manuel is no better. :-) Please avoid leaving unquoted patch behind your reply. WBR, Sergei