Re: [PATCH v2] Alchemy: cpu feature override constants.

[Sergei Shtylyov <sshtylyov@ru.mvista.com>]

Hello.

Manuel Lauss wrote:

> Add cpu feature override constants for Alchemy.
>
> This helps code generation: fls() for instance is compiled without
> using the clz instruction; other macros which do runtime feature
> detection fall back on safe legacy code as well.  Adding this override
> fixes that.  As a sideeffect, the size of a kernel built with an
> extended db1200 defconfig is reduced by over 200kB:
>
>    text    data     bss     dec     hex filename
> 3901089  124160  436528 4461777  4414d1 vmlinux
> 3676433  124096  436528 4237057  40a701 vmlinux-patched
>   

   Great!

> Signed-off-by: Manuel Lauss <mano@roarinelk.homelinux.net>
>   

   The whitespace police on the road. :-)

> diff --git a/arch/mips/include/asm/mach-au1x00/cpu-feature-overrides.h b/arch/mips/include/asm/mach-au1x00/cpu-feature-overrides.h
> new file mode 100644
> index 0000000..c22492e
> --- /dev/null
> +++ b/arch/mips/include/asm/mach-au1x00/cpu-feature-overrides.h
> @@ -0,0 +1,51 @@
>   
[...]
> +
> +#define cpu_dcache_line_size()	32
> +#define cpu_icache_line_size()  32
>   

   Inconsistent alignment.

WBR, Sergei