From: "tiejun.chen" <tiejun.chen@windriver.com>
To: Ralf Baechle <ralf@linux-mips.org>
Cc: linux-mips@linux-mips.org
Subject: Re: Defconfigs and RTC
Date: Tue, 02 Dec 2008 09:32:01 +0800 [thread overview]
Message-ID: <49349011.4000602@windriver.com> (raw)
In-Reply-To: <20081201105124.GB2277@linux-mips.org>
Ralf Baechle wrote:
> On Mon, Dec 01, 2008 at 04:50:14PM +0800, tiejun.chen wrote:
>
>> Ralf Baechle wrote:
>>> Quite a few of the defconfigs have not been updated for quite some time
>>> and are beginning to be a bit useless. Also since we switched to RTC_LIB
>>> quite a few systems no longer read their RTCs on bootup so their
>>> defconfigs should be updated to enable RTC_CLASS and CONFIG_RTC_HCTOSYS.
>>> A hand full of systems is still using read_persistent_clock() to read
>>> the RTC on bootup. The use of this function should preferably be replaced
>>> by RTC_CLASS and CONFIG_RTC_HCTOSYS.
>>>
>> Can we use RTC_CLASS option directly to replace RTC_LIB on the file,
>> arch/mips/Kconfig by default? If so all deconfigs may not be modified.
>
> RTC_CLASS implies RTC_LIB. It's not a replacement.
>
I meas if we use directly RTC_CLASS on the file, arch/mips/Kconfig, as the
following:
==
config MIPS
bool
default y
select HAVE_IDE
select HAVE_OPROFILE
select HAVE_ARCH_KGDB
# Horrible source of confusion. Die, die, die ...
select EMBEDDED
select RTC_LIB --> RTC_CLASS
===
If so RTC_Class and RTC_HCTOSYS options will be enabled for all platforms by
default as you expect. I think it will be given a hint for the developers that
they should develop their RTC towards supporting RTC_CLASS in the future, not
other choices. And it may be helpful to have an unified RTC mode quickly.
Thanks & Best Regards
Tiejun
> Ralf
>
prev parent reply other threads:[~2008-12-02 1:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-01 8:33 Defconfigs and RTC Ralf Baechle
2008-12-01 8:50 ` tiejun.chen
2008-12-01 10:51 ` Ralf Baechle
2008-12-02 1:32 ` tiejun.chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49349011.4000602@windriver.com \
--to=tiejun.chen@windriver.com \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox