From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Thu, 08 Jan 2009 19:43:06 +0000 (GMT) Received: from mail3.caviumnetworks.com ([12.108.191.235]:25459 "EHLO mail3.caviumnetworks.com") by ftp.linux-mips.org with ESMTP id S21103357AbZAHTnE (ORCPT ); Thu, 8 Jan 2009 19:43:04 +0000 Received: from exch4.caveonetworks.com (Not Verified[192.168.16.23]) by mail3.caviumnetworks.com with MailMarshal (v6,2,2,3503) id ; Thu, 08 Jan 2009 14:42:51 -0500 Received: from exch4.caveonetworks.com ([192.168.16.23]) by exch4.caveonetworks.com with Microsoft SMTPSVC(6.0.3790.3959); Thu, 8 Jan 2009 11:42:04 -0800 Received: from dd1.caveonetworks.com ([64.169.86.201]) by exch4.caveonetworks.com with Microsoft SMTPSVC(6.0.3790.3959); Thu, 8 Jan 2009 11:42:04 -0800 Message-ID: <4966570C.9010300@caviumnetworks.com> Date: Thu, 08 Jan 2009 11:42:04 -0800 From: David Daney User-Agent: Thunderbird 2.0.0.19 (X11/20090105) MIME-Version: 1.0 To: "Kevin D. Kissell" CC: Ihar Hrachyshka , linux-mips@linux-mips.org Subject: Re: NXP STB225 board support References: <496652B7.60500@paralogos.com> In-Reply-To: <496652B7.60500@paralogos.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 08 Jan 2009 19:42:04.0635 (UTC) FILETIME=[2EEBF2B0:01C971C9] Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 21693 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: ddaney@caviumnetworks.com Precedence: bulk X-list: linux-mips Kevin D. Kissell wrote: > Ihar Hrachyshka wrote: > > > > > > Bisecting my Linus vanilla git, I found that the problem appeared > > after the following patch was applied: > > > > > http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=566f74f6b2f8b85d5b8d6caaf97e5672cecd3e3e > > > > > After reverting the patch, Linus vanilla git kernel again boots ok on > > the board. Please, take a look. > > Could one of the Cavium guys explain why the new code for V2 cores does > "ebase += ..." and not "ebase = "? > We need to add the offset to the proper segment (CAC_BASE). That said, the change to set_uncached_handler looks incorrect. It should be adding onto uncached_ebase not ebase. Someone should probably fix that. David Daney