Linux MIPS Architecture development
 help / color / mirror / Atom feed
From: David Daney <ddaney@caviumnetworks.com>
To: linux-mips@linux-mips.org
Subject: Re: [PATCH] 8250: Initialize more fields in early_serial_setup.
Date: Wed, 14 Jan 2009 09:30:52 -0800	[thread overview]
Message-ID: <496E214C.4090206@caviumnetworks.com> (raw)
In-Reply-To: <1231879604-30140-1-git-send-email-ddaney@caviumnetworks.com>

David Daney wrote:
> The initial patch that initialized the fields individually omitted a
> couple that evidently are required by mips/rb532.  This should fix it.
> 
> Signed-off-by: David Daney <ddaney@caviumnetworks.com>
> ---
>  drivers/serial/8250.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/serial/8250.c b/drivers/serial/8250.c
> index 1889a63..e2c3a85 100644
> --- a/drivers/serial/8250.c
> +++ b/drivers/serial/8250.c
> @@ -2837,6 +2837,8 @@ int __init early_serial_setup(struct uart_port *port)
>  	p->regshift     = port->regshift;
>  	p->iotype       = port->iotype;
>  	p->flags        = port->flags;
> +	p->type		= port->type;
> +	p->line		= port->line;
>  	p->mapbase      = port->mapbase;
>  	p->private_data = port->private_data;
>  
Some one got to this before I did.  Linus already committed a 
substantially similar patch as  125c97d8a59888c5678734c2b70cbd08c847bd99

David Daney

      reply	other threads:[~2009-01-14 17:31 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-13 20:46 [PATCH] 8250: Initialize more fields in early_serial_setup David Daney
2009-01-14 17:30 ` David Daney [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=496E214C.4090206@caviumnetworks.com \
    --to=ddaney@caviumnetworks.com \
    --cc=linux-mips@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox