From: "Kevin D. Kissell" <kevink@paralogos.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org
Subject: Re: Strange initialization in arch/mips/kernel/smtc.c:1094?
Date: Mon, 09 Feb 2009 05:57:28 -0600 [thread overview]
Message-ID: <49901A28.6030604@paralogos.com> (raw)
In-Reply-To: <200902092149.16573.rusty@rustcorp.com.au>
Rusty Russell wrote:
> Latest Linus kernel, but it's been there a while:
>
> static struct irqaction irq_ipi = {
> .handler = ipi_interrupt,
> .flags = IRQF_DISABLED,
> .name = "SMTC_IPI",
> .flags = IRQF_PERCPU
> };
>
> .flags is initialized twice: I'm amazed this even compiles.
>
I don't know where that came from. The very earliest versions of smtc.c
didn't have a declaration initialization at all, but filled the fields
in setup_cross_vpe_interrupts(). The IRQ was PERCPU since day one. The
initial DISABLED state came later. I'm guessing someone added that
hastily and didn't notice the pre-existing .flags definition. I'm
curious as to which bit(s) are actually set.
Regards,
Kevin K.
prev parent reply other threads:[~2009-02-09 11:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-09 11:19 Strange initialization in arch/mips/kernel/smtc.c:1094? Rusty Russell
2009-02-09 11:57 ` Kevin D. Kissell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49901A28.6030604@paralogos.com \
--to=kevink@paralogos.com \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox