From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Manuel Lauss <mano@roarinelk.homelinux.net>
Cc: Linux-MIPS <linux-mips@linux-mips.org>
Subject: Re: [PATCH 1/3] Alchemy: get rid of common/platform.c
Date: Sun, 29 Mar 2009 15:37:05 +0400 [thread overview]
Message-ID: <49CF5D61.7090104@ru.mvista.com> (raw)
In-Reply-To: <1238318822-4772-2-git-send-email-mano@roarinelk.homelinux.net>
Hello.
Manuel Lauss wrote:
> Move device registration out of common/platform.c into the individual
> boards' platform.c files.
>
> Every board should register the devices it wants to use (i.e. on one
> of my Au1200 systems UART1 is unused [pinmux problems] and its
> functionality is provided by an external device. This also results
> in a completely useless ttyS1 entry; I want this entry gone without
> having to add a lot more #ifdef <platform> lines to common/platform.c).
>
No #ifdef's would be needed at all if you check what devices are
enabled before registering.
> Signed-off-by: Manuel Lauss <mano@roarinelk.homelinux.net>
>
NAK.
WBR. Sergei
next prev parent reply other threads:[~2009-03-29 11:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-29 9:26 [PATCH 0/3] Alchemy: platform updates Manuel Lauss
2009-03-29 9:27 ` [PATCH 1/3] Alchemy: get rid of common/platform.c Manuel Lauss
2009-03-29 9:27 ` [PATCH 2/3] Alchemy: add RTC device to devboards Manuel Lauss
2009-03-29 9:27 ` [PATCH 3/3] Alchemy: convert to physmap flash Manuel Lauss
2009-04-06 7:57 ` Florian Fainelli
2009-03-29 11:36 ` [PATCH 1/3] Alchemy: get rid of common/platform.c Sergei Shtylyov
2009-03-29 11:37 ` Sergei Shtylyov [this message]
2009-03-29 11:35 ` [PATCH 0/3] Alchemy: platform updates Sergei Shtylyov
2009-03-29 12:38 ` Manuel Lauss
2009-03-29 13:03 ` Sergei Shtylyov
2009-03-29 15:27 ` Kevin Hickey
2009-03-29 15:52 ` Manuel Lauss
2009-03-30 8:39 ` Florian Fainelli
2009-03-30 16:23 ` Ralf Baechle
2009-03-29 15:43 ` Manuel Lauss
2009-03-29 20:48 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49CF5D61.7090104@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=linux-mips@linux-mips.org \
--cc=mano@roarinelk.homelinux.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox