From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: yanhua <yanh@lemote.com>
Cc: linux-mips@linux-mips.org, "Ralf Baechle" <ralf@linux-mips.org>,
彭亮锦 <penglj@lemote.com>,
"zhangfx@lemote.com" <zhangfx@lemote.com>
Subject: Re: [PATCH 10/14] lemote: rtc driver binary mode support
Date: Thu, 09 Apr 2009 15:55:48 +0400 [thread overview]
Message-ID: <49DDE244.6030606@ru.mvista.com> (raw)
In-Reply-To: <49DD8238.7060609@lemote.com>
yanhua wrote:
> The original driver will exit when detect rtc binary mode. In fact both
> the binary mode and bcd are supported
[...]
> diff --git a/drivers/rtc/rtc-cmos.c b/drivers/rtc/rtc-cmos.c
> index b6d35f5..85c327e 100644
> --- a/drivers/rtc/rtc-cmos.c
> +++ b/drivers/rtc/rtc-cmos.c
> @@ -757,7 +757,7 @@ cmos_do_probe(struct device *dev, struct resource
> *ports, int rtc_irq)
> * <asm-generic/rtc.h> doesn't know 12-hour mode either.
> */
> if (is_valid_irq(rtc_irq) &&
> - (!(rtc_control & RTC_24H) || (rtc_control & (RTC_DM_BINARY)))) {
> + (!(rtc_control & RTC_24H) /*|| (rtc_control & (RTC_DM_BINARY))*/)) {
> dev_dbg(dev, "only 24-hr BCD mode supported\n");
Perhaps the message should be changed too then...
> retval = -ENXIO;
> goto cleanup1;
WBR, Sergei
next prev parent reply other threads:[~2009-04-09 11:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-09 5:06 [PATCH 10/14] lemote: rtc driver binary mode support yanhua
2009-04-09 11:55 ` Sergei Shtylyov [this message]
2009-04-13 10:48 ` Zhang Le
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49DDE244.6030606@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=linux-mips@linux-mips.org \
--cc=penglj@lemote.com \
--cc=ralf@linux-mips.org \
--cc=yanh@lemote.com \
--cc=zhangfx@lemote.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox