From: Roel Kluin <roel.kluin@gmail.com>
To: rjw@sisk.pl, ralf@linux-mips.org,
linux-pm@lists.linux-foundation.org, linux-mips@linux-mips.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: [PATCH] mips: decrease size of au1xxx_dbdma_pm_regs[][]
Date: Tue, 21 Jul 2009 14:46:51 +0200 [thread overview]
Message-ID: <4A65B8BB.40502@gmail.com> (raw)
Only registers [0-DDMA_CHANNEL_BASE][0-6] are used by the suspend
and resume routines.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
These routines are on the bottom of the file. Only used are
registers:
au1xxx_dbdma_pm_regs[0][0-3]
and
au1xxx_dbdma_pm_regs[1-NUM_DBDMA_CHANS][0-6]
Is my patch right, that assumes that the array can be smaller, or
should the storage and recovery of other registers be added?
Roel
diff --git a/arch/mips/alchemy/common/dbdma.c b/arch/mips/alchemy/common/dbdma.c
index 3ab6d80..bf48a21 100644
--- a/arch/mips/alchemy/common/dbdma.c
+++ b/arch/mips/alchemy/common/dbdma.c
@@ -175,7 +175,7 @@ static dbdev_tab_t dbdev_tab[] = {
#define DBDEV_TAB_SIZE ARRAY_SIZE(dbdev_tab)
#ifdef CONFIG_PM
-static u32 au1xxx_dbdma_pm_regs[NUM_DBDMA_CHANS + 1][8];
+static u32 au1xxx_dbdma_pm_regs[NUM_DBDMA_CHANS][7];
#endif
next reply other threads:[~2009-07-21 12:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-21 12:46 Roel Kluin [this message]
2009-07-21 13:06 ` [PATCH] mips: decrease size of au1xxx_dbdma_pm_regs[][] Manuel Lauss
-- strict thread matches above, loose matches on Subject: below --
2009-07-21 14:19 Roel Kluin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A65B8BB.40502@gmail.com \
--to=roel.kluin@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=ralf@linux-mips.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).