Re: MTX build failure

[Manuel Lauss <manuel.lauss@googlemail.com>]

I wrote:
> Ralf Baechle wrote:
>>   CC      drivers/input/keyboard/gpio_keys.o
>> /home/ralf/src/linux/linux-mips/drivers/input/keyboard/gpio_keys.c: In function ‘gpio_keys_probe’:
>> /home/ralf/src/linux/linux-mips/drivers/input/keyboard/gpio_keys.c:123: error: implicit declaration of function ‘gpio_request’
>> /home/ralf/src/linux/linux-mips/drivers/input/keyboard/gpio_keys.c:135: error: implicit declaration of function ‘gpio_free’
>> make[5]: *** [drivers/input/keyboard/gpio_keys.o] Error 1
>> make[4]: *** [drivers/input/keyboard] Error 2
>> make[3]: *** [drivers/input] Error 2
>> make[2]: *** [drivers] Error 2
>> make[1]: *** [sub-make] Error 2
> 
> Either something like the patch below, or adding stubs for
> gpio_request/gpio_free to asm/mach-au1x00/gpio-au1000.h in the
> CONFIG_GPIOLIB=n case should fix it.

Florian, Ralf, I prefer the latter approach;  saves everyone from
having to add #ifdef CONFIG_GPIOLIB around gpio_request() calls.

Here's an untested patch.  What do you think?  If it works for you, please
add it to your patchqueue!

Thanks!

---

From: Manuel Lauss <manuel.lauss@gmail.com>
Subject: [PATCH] Alchemy: add gpio_request/gpio_free stubs for CONFIG_GPIOLIB=n

Some drivers use gpio_request/gpio_free regardless of whether
gpiolib is actually built;  add stubs to work around the ensuing
compile failures.

Signed-off-by: Manuel Lauss <manuel.lauss@gmail.com>
---
 arch/mips/include/asm/mach-au1x00/gpio-au1000.h |    9 +++++++++
 1 files changed, 9 insertions(+), 0 deletions(-)

diff --git a/arch/mips/include/asm/mach-au1x00/gpio-au1000.h b/arch/mips/include/asm/mach-au1x00/gpio-au1000.h
index 127d4ed..feea001 100644
--- a/arch/mips/include/asm/mach-au1x00/gpio-au1000.h
+++ b/arch/mips/include/asm/mach-au1x00/gpio-au1000.h
@@ -578,6 +578,15 @@ static inline int irq_to_gpio(int irq)
 	return alchemy_irq_to_gpio(irq);
 }

+static inline int gpio_request(unsigned gpio, const char *label)
+{
+	return 0;
+}
+
+static inline void gpio_free(unsigned gpio)
+{
+}
+
 #endif	/* !CONFIG_ALCHEMY_GPIO_INDIRECT */


--
1.6.4.1