* [PATCH] MIPS: TXx9: Fix error handling / Fix for noenexisting gpio_remove.
@ 2009-09-16 6:01 Ralf Roesch
2009-09-17 13:52 ` Atsushi Nemoto
0 siblings, 1 reply; 5+ messages in thread
From: Ralf Roesch @ 2009-09-16 6:01 UTC (permalink / raw)
To: linux-mips
error was introduced by commit 0385d1f3d394c6814be0b165c153fc3fc254469a
Signed-off-by: Ralf Roesch <ralf.roesch@rw-gmbh.de>
---
arch/mips/txx9/generic/setup.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/arch/mips/txx9/generic/setup.c b/arch/mips/txx9/generic/setup.c
index ed794c1..cff5578 100644
--- a/arch/mips/txx9/generic/setup.c
+++ b/arch/mips/txx9/generic/setup.c
@@ -835,7 +835,8 @@ void __init txx9_iocled_init(unsigned long baseaddr,
out_pdev:
platform_device_put(pdev);
out_gpio:
- gpio_remove(&iocled->chip);
+ if (gpiochip_remove(&iocled->chip))
+ return;
out_unmap:
iounmap(iocled->mmioaddr);
out_free:
--
1.6.3.3
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] MIPS: TXx9: Fix error handling / Fix for noenexisting gpio_remove.
2009-09-16 6:01 [PATCH] MIPS: TXx9: Fix error handling / Fix for noenexisting gpio_remove Ralf Roesch
@ 2009-09-17 13:52 ` Atsushi Nemoto
2009-09-18 8:12 ` Ralf Roesch
2009-09-18 16:22 ` Sergei Shtylyov
0 siblings, 2 replies; 5+ messages in thread
From: Atsushi Nemoto @ 2009-09-17 13:52 UTC (permalink / raw)
To: ralf.roesch; +Cc: linux-mips, Julia Lawall
On Wed, 16 Sep 2009 08:01:20 +0200, Ralf Roesch <ralf.roesch@rw-gmbh.de> wrote:
> error was introduced by commit 0385d1f3d394c6814be0b165c153fc3fc254469a
Thanks, this patch should be holded into the original commit before
mainlining. The result should be same as Julia's revised patch.
I don't mind ether way, I just hope keeping bisectability on mainline.
Is it too late, (yet another) Ralf ?
---
Atsushi Nemoto
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] MIPS: TXx9: Fix error handling / Fix for noenexisting gpio_remove.
2009-09-17 13:52 ` Atsushi Nemoto
@ 2009-09-18 8:12 ` Ralf Roesch
2009-09-18 16:22 ` Sergei Shtylyov
1 sibling, 0 replies; 5+ messages in thread
From: Ralf Roesch @ 2009-09-18 8:12 UTC (permalink / raw)
To: Atsushi Nemoto; +Cc: linux-mips, Julia Lawall
On Thu Sep 17 2009 15:52:59 GMT+0200 (CEST), Atsushi Nemoto wrote:
> Thanks, this patch should be holded into the original commit before
> mainlining. The result should be same as Julia's revised patch.
>
> I don't mind ether way, I just hope keeping bisectability on mainline.
> Is it too late, (yet another) Ralf ?
>
>
Not for me Atshushi, thanks.
--
the other Ralf ;-)
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] MIPS: TXx9: Fix error handling / Fix for noenexisting gpio_remove.
2009-09-17 13:52 ` Atsushi Nemoto
2009-09-18 8:12 ` Ralf Roesch
@ 2009-09-18 16:22 ` Sergei Shtylyov
2009-09-25 13:57 ` Atsushi Nemoto
1 sibling, 1 reply; 5+ messages in thread
From: Sergei Shtylyov @ 2009-09-18 16:22 UTC (permalink / raw)
To: Atsushi Nemoto; +Cc: ralf.roesch, linux-mips, Julia Lawall
Hello.
Atsushi Nemoto wrote:
>>error was introduced by commit 0385d1f3d394c6814be0b165c153fc3fc254469a
> Thanks, this patch should be holded into the original commit before
> mainlining. The result should be same as Julia's revised patch.
> I don't mind ether way, I just hope keeping bisectability on mainline.
> Is it too late, (yet another) Ralf ?
Well, Ralf B. has already committed Julia's broken patch at 9/14.
> ---
> Atsushi Nemoto
WBR, Sergei
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] MIPS: TXx9: Fix error handling / Fix for noenexisting gpio_remove.
2009-09-18 16:22 ` Sergei Shtylyov
@ 2009-09-25 13:57 ` Atsushi Nemoto
0 siblings, 0 replies; 5+ messages in thread
From: Atsushi Nemoto @ 2009-09-25 13:57 UTC (permalink / raw)
To: sshtylyov; +Cc: ralf.roesch, linux-mips, julia
On Fri, 18 Sep 2009 20:22:17 +0400, Sergei Shtylyov <sshtylyov@ru.mvista.com> wrote:
> > I don't mind ether way, I just hope keeping bisectability on mainline.
> > Is it too late, (yet another) Ralf ?
>
> Well, Ralf B. has already committed Julia's broken patch at 9/14.
Then,
Acked-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
---
Atsushi Nemoto
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2009-09-25 13:57 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-09-16 6:01 [PATCH] MIPS: TXx9: Fix error handling / Fix for noenexisting gpio_remove Ralf Roesch
2009-09-17 13:52 ` Atsushi Nemoto
2009-09-18 8:12 ` Ralf Roesch
2009-09-18 16:22 ` Sergei Shtylyov
2009-09-25 13:57 ` Atsushi Nemoto
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).