From: David Daney <ddaney@caviumnetworks.com>
To: "Maciej W. Rozycki" <macro@linux-mips.org>
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org
Subject: Re: [PATCH 2/2] MIPS: Put PGD in C0_CONTEXT for 64-bit R2 processors.
Date: Thu, 15 Oct 2009 13:10:59 -0700 [thread overview]
Message-ID: <4AD781D3.60503@caviumnetworks.com> (raw)
In-Reply-To: <alpine.LFD.2.00.0910152104020.20490@eddie.linux-mips.org>
Maciej W. Rozycki wrote:
> On Wed, 14 Oct 2009, David Daney wrote:
>
>> @@ -1406,6 +1424,7 @@ void __cpuinit build_tlb_refill_handler(void)
>> case CPU_TX3912:
>> case CPU_TX3922:
>> case CPU_TX3927:
>> +#ifndef CONFIG_MIPS_PGD_C0_CONTEXT
>> build_r3000_tlb_refill_handler();
>> if (!run_once) {
>> build_r3000_tlb_load_handler();
>> @@ -1413,6 +1432,9 @@ void __cpuinit build_tlb_refill_handler(void)
>> build_r3000_tlb_modify_handler();
>> run_once++;
>> }
>> +#else
>> + panic("No R3000 TLB refill handler");
>> +#endif
>> break;
>>
>> case CPU_R6000:
>
> Shouldn't this be #error or suchlike instead?
>
I don't think so. It is a runtime check. The kernel was configured in
such a manner that those CPUs cannot be supported. By the time the
problem is detected, the preprocessor (and compiler in general) have
already been run.
David Daney
> Maciej
>
next prev parent reply other threads:[~2009-10-15 20:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-14 19:15 [PATCH 0/2] MIPS: Put PGD in C0_CONTEXT for 64-bit R2 processors David Daney
2009-10-14 19:16 ` [PATCH 1/2] MIPS: Add drotr and dins instructions to uasm David Daney
2009-10-15 9:35 ` Ralf Baechle
2009-10-14 19:16 ` [PATCH 2/2] MIPS: Put PGD in C0_CONTEXT for 64-bit R2 processors David Daney
2009-10-15 9:36 ` Ralf Baechle
2009-10-15 20:05 ` Maciej W. Rozycki
2009-10-15 20:10 ` David Daney [this message]
2009-10-15 20:23 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AD781D3.60503@caviumnetworks.com \
--to=ddaney@caviumnetworks.com \
--cc=linux-mips@linux-mips.org \
--cc=macro@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).