From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Mon, 16 Nov 2009 16:47:29 +0100 (CET) Received: from mail-fx0-f211.google.com ([209.85.220.211]:33850 "EHLO mail-fx0-f211.google.com" rhost-flags-OK-OK-OK-OK) by ftp.linux-mips.org with ESMTP id S1492774AbZKPPrW (ORCPT ); Mon, 16 Nov 2009 16:47:22 +0100 Received: by fxm3 with SMTP id 3so1221504fxm.24 for ; Mon, 16 Nov 2009 07:47:14 -0800 (PST) Received: by 10.204.25.66 with SMTP id y2mr5621694bkb.59.1258386433870; Mon, 16 Nov 2009 07:47:13 -0800 (PST) Received: from monstr.eu (gw.wifiinternet.cz [89.31.42.6]) by mx.google.com with ESMTPS id 18sm3992291fks.0.2009.11.16.07.47.11 (version=SSLv3 cipher=RC4-MD5); Mon, 16 Nov 2009 07:47:12 -0800 (PST) Message-ID: <4B0173FD.4000104@monstr.eu> Date: Mon, 16 Nov 2009 16:47:09 +0100 From: Michal Simek Reply-To: monstr@monstr.eu User-Agent: Thunderbird 2.0.0.22 (X11/20090625) MIME-Version: 1.0 To: Thomas Gleixner CC: Wu Zhangjin , rostedt@goodmis.org, Ralf Baechle , Frederic Weisbecker , Ingo Molnar , Nicholas Mc Guire , David Daney , Richard Sandiford , Patrik Kluba , "Maciej W . Rozycki" , linux-mips@linux-mips.org, linux-kernel@vger.kernel.org, zhangfx@lemote.com, zhouqg@gmail.com Subject: Re: [PATCH v8 01/16] tracing: convert trace_clock_local() as weak function References: <9dc81a7a9e5a292cccdf465c533a2b08d19d6021.1258177321.git.wuzhangjin@gmail.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 24920 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: monstr@monstr.eu Precedence: bulk X-list: linux-mips Thomas Gleixner wrote: > On Sat, 14 Nov 2009, Wu Zhangjin wrote: > >> From: Wu Zhangjin >> >> trace_clock_local() is based on the arch-specific sched_clock(), in X86, >> it is tsc(64bit) based, which can give very high precision(about 1ns >> with 1GHz). but in MIPS, the sched_clock() is jiffies based, which can >> give only 10ms precison with 1000 HZ. which is not enough for tracing, >> especially for Real Time system. >> >> so, we need to implement a MIPS specific sched_clock() to get higher >> precision. There is a tsc like clock counter register in MIPS, whose >> frequency is half of the processor, so, if the cpu frequency is 800MHz, >> the time precision reaches 2.5ns, which is very good for tracing, even >> for Real Time system. >> >> but 'Cause it is only 32bit long, which will rollover quickly, so, such >> a sched_clock() will bring with extra load, which is not good for the >> whole system. so, we only need to implement a arch-specific >> trace_clock_local() for tracing. as a preparation, we convert it as a >> weak function. > > Hmm, I'm not convinced that this is really a huge overhead. > > First of all the rollover happens once every 10 seconds on a 800MHz > machine. > > Secondly we have a lockless implementation of extending 32bit counters > to 63 bit which is used at least by ARM to provide a high resolution > sched_clock implementation. See include/linux/cnt32_63.h and the users > in arch/ > > But that's a problem which can be discussed seperately and does not > affect the rest of the tracing infrastructure. I really would > recommend that you implement a sched_clock for the r4k machines based > on cnt32_63 and measure the overhead. Having a fine granular > sched_clock in general is probably not a bad thing. please cc me on this discuss too. I have working ftrace implementation in my tree and I need improve timing too. I have similar patch as MIPS use. But I am not able to use it via timecounters. Something is weird there that's why I am open to find out any sensible and accepted solution. Thanks, Michal > > Thanks, > > tglx -- Michal Simek, Ing. (M.Eng) w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/ Microblaze U-BOOT custodian