Linux MIPS Architecture development
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: wuzhangjin@gmail.com
Cc: Ralf Baechle <ralf@linux-mips.org>,
	linux-mips@linux-mips.org, zhangfx@lemote.com, yanh@lemote.com,
	huhb@lemote.com, Richard Purdie <rpurdie@rpsys.net>,
	lm-sensors@lm-sensors.org, Jamey Hicks <jamey@crl.dec.com>
Subject: Re: [PATCH 5/5] [loongson] yeeloong2f: add platform specific support
Date: Fri, 20 Nov 2009 00:42:30 +0300	[thread overview]
Message-ID: <4B05BBC6.2010000@ru.mvista.com> (raw)
In-Reply-To: <1258653766.14308.13.camel@falcon.domain.org>

Hello.

Wu Zhangjin wrote:

> Sorry, This patch can not be compiled without CONFIG_PM, this patch is
> needed to fix it:
>
> We need to wrap the source code relative to CONFIG_PM, otherwise, it
> will fail in compiling.
>
> This patch is needed to "[PATCH 5/5] [loongson] yeeloong2f: add platform
> specific support".
>
> Signed-off-by: Wu Zhangjin <wuzhangjin@gmail.com>
> ---
>  arch/mips/loongson/lemote-2f/yeeloong_laptop.c |   12 ++++++++----
>  1 files changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/arch/mips/loongson/lemote-2f/yeeloong_laptop.c
> b/arch/mips/loongson/lemote-2f/yeeloong_laptop.c
> index ff74f7f..46c3847 100644
> --- a/arch/mips/loongson/lemote-2f/yeeloong_laptop.c
> +++ b/arch/mips/loongson/lemote-2f/yeeloong_laptop.c
> @@ -1025,9 +1025,10 @@ static int yeeloong_hotkey_init(struct device
> *dev)
>  	/* update the current status of lid */
>  	yeeloong_lid_update_status(BIT_LID_DETECT_ON);
>  
> +#ifdef CONFIG_SUSPEND
>  	/* install the real yeeloong_report_lid_status for pm.c */
>  	yeeloong_report_lid_status = yeeloong_lid_update_status;
> -
> +#endif
>  	/* install event handler */
>  	yeeloong_install_sci_handler(EVENT_CAMERA, camera_set);
>  
> @@ -1039,9 +1040,10 @@ static void yeeloong_hotkey_exit(void)
>  	/* free irq */
>  	remove_irq(SCI_IRQ_NUM, &sci_irqaction);
>  
> +#ifdef CONFIG_SUSPEND
>  	/* uninstall the real yeeloong_report_lid_status for pm.c */
>  	yeeloong_report_lid_status = NULL;
> -
> +#endif
>  	/* uninstall event handler */
>  	yeeloong_uninstall_sci_handler(EVENT_CAMERA, camera_set);
>  
> @@ -1083,7 +1085,8 @@ static void get_fixed_battery_info(void)
>  
>  #define APM_CRITICAL		5
>  
> -static void yeeloong_apm_get_power_status(struct apm_power_info *info)
> +static void __maybe_unused yeeloong_apm_get_power_status(struct
> apm_power_info
> +		*info)
>   

   Your patch is line-wrapped.

WBR, Sergei

  reply	other threads:[~2009-11-19 21:43 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-19 17:32 [PATCH 0/5] Lemote-2f: Add Platform Specific Support Wu Zhangjin
2009-11-19 17:33 ` [PATCH 1/5] [loongson] LynLoong2F: " Wu Zhangjin
2009-11-19 17:33 ` [PATCH 2/5] [loongson] yeeloong2f: add basic ec operations Wu Zhangjin
2009-11-19 17:34 ` [PATCH 3/5] [loongson] yeeloong2f: add LID open event as the wakeup event Wu Zhangjin
2009-11-19 17:34 ` [PATCH 4/5] [loongson] yeeloong2f: cleanup the reset logic with ec_write function Wu Zhangjin
2009-11-19 17:39 ` [PATCH 5/5] [loongson] yeeloong2f: add platform specific support Wu Zhangjin
2009-11-19 18:02   ` Wu Zhangjin
2009-11-19 21:42     ` Sergei Shtylyov [this message]
2009-11-20  1:08       ` Wu Zhangjin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B05BBC6.2010000@ru.mvista.com \
    --to=sshtylyov@ru.mvista.com \
    --cc=huhb@lemote.com \
    --cc=jamey@crl.dec.com \
    --cc=linux-mips@linux-mips.org \
    --cc=lm-sensors@lm-sensors.org \
    --cc=ralf@linux-mips.org \
    --cc=rpurdie@rpsys.net \
    --cc=wuzhangjin@gmail.com \
    --cc=yanh@lemote.com \
    --cc=zhangfx@lemote.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox