From: David Daney <ddaney@caviumnetworks.com>
To: Roel Kluin <roel.kluin@gmail.com>
Cc: Ralf Baechle <ralf@linux-mips.org>,
linux-mips@linux-mips.org,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] MIPS: cleanup switches with cases that can be merged
Date: Tue, 19 Jan 2010 18:02:06 -0800 [thread overview]
Message-ID: <4B56641E.1030803@caviumnetworks.com> (raw)
In-Reply-To: <4B56475F.8070608@gmail.com>
Roel Kluin wrote:
> I did a search for switch statements with cases that can be merged, but maybe
> some were not intended?
> ---------------->8------------------------------------------8<-----------------
> In these cases the same code was executed.
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
> arch/mips/include/asm/octeon/octeon-feature.h | 8 ++------
> arch/mips/kernel/cpu-probe.c | 3 ---
> arch/mips/math-emu/ieee754dp.c | 1 -
> arch/mips/math-emu/ieee754sp.c | 1 -
> arch/mips/pci/pci-octeon.c | 6 ++----
> arch/mips/powertv/asic/asic_devices.c | 4 ----
> arch/mips/sgi-ip32/ip32-irq.c | 9 +--------
> 7 files changed, 5 insertions(+), 27 deletions(-)
This patch should be split up.
Octeon, PowerTV, and IP32 are all different architectures. They should
be in their own patches.
The two math-emu parts could probably go together.
cpu-probe seems like its own thing.
This brings us to the larger question: This is just code churn. Is it
even worthwhile?
David Daney
next prev parent reply other threads:[~2010-01-20 2:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-19 23:59 [PATCH] MIPS: cleanup switches with cases that can be merged Roel Kluin
2010-01-20 2:02 ` David Daney [this message]
2010-01-20 11:47 ` Alexander Clouter
2010-01-23 16:31 ` Ralf Baechle
2010-01-24 0:23 ` Ralf Baechle
2010-01-24 17:58 ` 1 GB RAM with RM9000 SOC Anoop P.A.
2010-01-24 17:58 ` Anoop P.A.
2010-01-25 17:15 ` David Daney
2010-01-25 17:34 ` Anoop P.A.
2010-01-25 17:34 ` Anoop P.A.
2010-01-25 17:38 ` David Daney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B56641E.1030803@caviumnetworks.com \
--to=ddaney@caviumnetworks.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=roel.kluin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).