linux-mips.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Daney <ddaney@caviumnetworks.com>
To: Yang Shi <yang.shi@windriver.com>
Cc: ralf@linux-mips.org, f.fainelli@gmail.com, linux-mips@linux-mips.org
Subject: Re: [PATCH 1/3] MIPS: Octeon: Remove superfluous on_each_cpu parameter
Date: Wed, 03 Mar 2010 09:53:01 -0800	[thread overview]
Message-ID: <4B8EA1FD.5050007@caviumnetworks.com> (raw)
In-Reply-To: <fd8fb199609e60a5b6c10e2073976a3f6b599109.1267604875.git.yang.shi@windriver.com>

On 03/03/2010 12:43 AM, Yang Shi wrote:
> Now, on_each_cpu just need three parameters, but the on_each_cpu
> still uses four parameters in Octeon's setup.c. So, remove the
> superfluous parameter.
>
> Signed-off-by: Yang Shi<yang.shi@windriver.com>


NAK!  We are removing CONFIG_CAVIUM_RESERVE32_USE_WIRED_TLB completely.

I will send the removal patch soon.

David Daney

> ---
>   arch/mips/cavium-octeon/setup.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/mips/cavium-octeon/setup.c b/arch/mips/cavium-octeon/setup.c
> index b321d3b..4eaa35f 100644
> --- a/arch/mips/cavium-octeon/setup.c
> +++ b/arch/mips/cavium-octeon/setup.c
> @@ -230,7 +230,7 @@ static void octeon_hal_setup_per_cpu_reserved32(void *unused)
>   void octeon_hal_setup_reserved32(void)
>   {
>   #ifdef CONFIG_CAVIUM_RESERVE32_USE_WIRED_TLB
> -	on_each_cpu(octeon_hal_setup_per_cpu_reserved32, NULL, 0, 1);
> +	on_each_cpu(octeon_hal_setup_per_cpu_reserved32, NULL, 1);
>   #endif
>   }
>

  parent reply	other threads:[~2010-03-03 17:56 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-03  8:43 [V2] Octeon: Several misc fixes Yang Shi
2010-03-03  8:43 ` [PATCH 1/3] MIPS: Octeon: Remove superfluous on_each_cpu parameter Yang Shi
2010-03-03  8:43   ` [PATCH 2/3] MIPS: Octeon: Remove redundant declaration of octeon_reserve32_memory Yang Shi
2010-03-03  8:43     ` [PATCH 3/3] MIPS: Octeon: Add add_wired_entry decralation in header file Yang Shi
2010-03-03 18:24       ` David Daney
2010-03-09 14:16         ` Ralf Baechle
2010-03-03 18:25     ` [PATCH 2/3] MIPS: Octeon: Remove redundant declaration of octeon_reserve32_memory David Daney
2010-03-11  0:52       ` Ralf Baechle
2010-03-03 17:53   ` David Daney [this message]
2010-03-04  2:08     ` [PATCH 1/3] MIPS: Octeon: Remove superfluous on_each_cpu parameter Yang Shi
  -- strict thread matches above, loose matches on Subject: below --
2010-03-03  7:26 Octeon: Several misc fixes Yang Shi
2010-03-03  7:26 ` [PATCH 1/3] MIPS: Octeon: Remove superfluous on_each_cpu parameter Yang Shi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B8EA1FD.5050007@caviumnetworks.com \
    --to=ddaney@caviumnetworks.com \
    --cc=f.fainelli@gmail.com \
    --cc=linux-mips@linux-mips.org \
    --cc=ralf@linux-mips.org \
    --cc=yang.shi@windriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).