From: Sergei Shtylyov <sshtylyov@mvista.com>
To: Manuel Lauss <manuel.lauss@googlemail.com>
Cc: Linux-MIPS <linux-mips@linux-mips.org>,
Manuel Lauss <manuel.lauss@gmail.com>
Subject: Re: [PATCH] MIPS: Alchemy: fix up residual devboard poweroff/reboot code.
Date: Fri, 26 Mar 2010 00:43:05 +0300 [thread overview]
Message-ID: <4BABD8E9.8030008@ru.mvista.com> (raw)
In-Reply-To: <1269542237-16617-1-git-send-email-manuel.lauss@gmail.com>
Hello.
Manuel Lauss wrote:
> Clean out stray unused board_reset() calls in pb1x boards,
> the pb1000 is different from the rest and gets private methods.
>
> Signed-off-by: Manuel Lauss <manuel.lauss@gmail.com>
>
[...]
> diff --git a/arch/mips/alchemy/devboards/pb1000/board_setup.c b/arch/mips/alchemy/devboards/pb1000/board_setup.c
> index b5311d8..9fa532c 100644
> --- a/arch/mips/alchemy/devboards/pb1000/board_setup.c
> +++ b/arch/mips/alchemy/devboards/pb1000/board_setup.c
>
[...]
> @@ -177,6 +187,10 @@ void __init board_setup(void)
> au_writel(au_readl(SYS_POWERCTRL) | (0x3 << 5), SYS_POWERCTRL);
> break;
> }
> +
> + pm_power_off = board_power_off;
> + _machine_halt = board_power_off;
> + _machine_restart = board_reset;
>
Why there are spaces after tabs?
WBR, Sergei
prev parent reply other threads:[~2010-03-25 21:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-25 18:37 [PATCH] MIPS: Alchemy: fix up residual devboard poweroff/reboot code Manuel Lauss
2010-03-25 21:43 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BABD8E9.8030008@ru.mvista.com \
--to=sshtylyov@mvista.com \
--cc=linux-mips@linux-mips.org \
--cc=manuel.lauss@gmail.com \
--cc=manuel.lauss@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox