Linux MIPS Architecture development
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sshtylyov@mvista.com>
To: yajin <yajinzhou@vm-kernel.org>
Cc: linux-mips@linux-mips.org,
	loongson-dev <loongson-dev@googlegroups.com>,
	wuzhangjin@gmail.com, apatard@mandriva.com, vince@simtec.co.uk,
	ben@simtec.co.uk
Subject: Re: [PATCH 8/12] gdium uses different freq of mclk&m1xclk of sm501
Date: Tue, 04 May 2010 14:19:06 +0400	[thread overview]
Message-ID: <4BDFF49A.9000404@mvista.com> (raw)
In-Reply-To: <q2u180e2c241005040255n628614a0p828116a04f65a894@mail.gmail.com>

Hello.

yajin wrote:

> Gdium uses different freq of mclk&m1xclk of sm501. This seems a dirty
> hack. Maybe we need a configuration option for changing the freq of
> these clocks.
>
> Signed-off-by: yajin <yajin@vm-kernel.org>
> ---
>  drivers/mfd/sm501.c |    9 +++++++--
>  1 files changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mfd/sm501.c b/drivers/mfd/sm501.c
> index ce5dfce..5e55cbd 100644
> --- a/drivers/mfd/sm501.c
> +++ b/drivers/mfd/sm501.c
> @@ -1606,10 +1606,15 @@ static struct sm501_initdata sm501_pci_initdata = {
>  	.devices	= SM501_USE_ALL,
>
>  	/* Errata AB-3 says that 72MHz is the fastest available
> -	 * for 33MHZ PCI with proper bus-mastering operation */
> -
> +	 * for 33MHZ PCI with proper bus-mastering operation
> +	 * For gdium, it works under 84&112M clock freq.*/
>   

   According to CodingStyle, style of multiline comments should 
preferably be:

/*
 * bla
 * bla
 * bla
 */

WBR, Sergei

  reply	other threads:[~2010-05-04 10:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-04  9:55 [PATCH 8/12] gdium uses different freq of mclk&m1xclk of sm501 yajin
2010-05-04 10:19 ` Sergei Shtylyov [this message]
2010-05-24 23:01 ` Ben Dooks
2010-05-25  3:30   ` yajin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BDFF49A.9000404@mvista.com \
    --to=sshtylyov@mvista.com \
    --cc=apatard@mandriva.com \
    --cc=ben@simtec.co.uk \
    --cc=linux-mips@linux-mips.org \
    --cc=loongson-dev@googlegroups.com \
    --cc=vince@simtec.co.uk \
    --cc=wuzhangjin@gmail.com \
    --cc=yajinzhou@vm-kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox