From: Wolfgang Grandegger <wg@grandegger.com>
To: Manuel Lauss <manuel.lauss@googlemail.com>
Cc: Linux-MIPS <linux-mips@linux-mips.org>,
Wolfgang Grandegger <wg@denx.de>,
Florian Fainelli <florian@openwrt.org>
Subject: Re: [RFC PATCH v2] au1000_eth: get ethernet address from platform_data
Date: Tue, 20 Jul 2010 12:10:54 +0200 [thread overview]
Message-ID: <4C45762E.70909@grandegger.com> (raw)
In-Reply-To: <1279544125-28104-1-git-send-email-manuel.lauss@googlemail.com>
Hi Manuel,
On 07/19/2010 02:55 PM, Manuel Lauss wrote:
> Modify au1000_eth to receive an ethernet address from platform data,
> or choose a random one.
>
> The default address is usually provided by the firmware; modify
> platform device registration to use it if the board code has not
> already overridden it.
>
> Cc: Wolfgang Grandegger <wg@denx.de>
> Cc: Florian Fainelli <florian@openwrt.org>
> Signed-off-by: Manuel Lauss <manuel.lauss@googlemail.com>
> ---
> v2: diffed against linus-git, on top of Wolfgang's patch
> "mips/alchemy: define eth platform devices in the correct order"
> This one should actually apply cleanly.
>
>
> IMHO a device driver should not call firmware-specific functions
> (be it MIPS-style prom_get_*(), OF properties or whatever) to
> get missing information. Instead this should be done by the
> platform code which sets up the device. This patch does just that.
>
> Compile-tested only. Florian, Wolfgang: could you please give this
> a try on your boards? If it works and you agree to it, I'll
> resubmit it also to linux-netdev. Thank you! (I don't have
> accessible au1000-eth hardware).
I gave the patch a try. The kernel builds and runs fine. The eth's are
realized in the correct order and do work properly. Feel free to add my
"Tested-by: Wolfgang Grandegger <wg@denx.de>".
Wolfgang,
next prev parent reply other threads:[~2010-07-20 10:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-19 12:55 [RFC PATCH v2] au1000_eth: get ethernet address from platform_data Manuel Lauss
2010-07-19 16:51 ` Wolfgang Grandegger
2010-07-20 10:10 ` Wolfgang Grandegger [this message]
2010-07-20 11:24 ` Florian Fainelli
2010-07-21 7:47 ` Manuel Lauss
2010-07-21 7:47 ` Manuel Lauss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C45762E.70909@grandegger.com \
--to=wg@grandegger.com \
--cc=florian@openwrt.org \
--cc=linux-mips@linux-mips.org \
--cc=manuel.lauss@googlemail.com \
--cc=wg@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox