From: John Reiser <jreiser@bitwagon.com>
To: Arnaud Lacombe <lacombar@gmail.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
linux-mips@linux-mips.org, wu zhangjin <wuzhangjin@gmail.com>
Subject: Re: Build failure triggered by recordmcount
Date: Mon, 22 Nov 2010 19:41:44 -0800 [thread overview]
Message-ID: <4CEB37F8.1050504@bitwagon.com> (raw)
In-Reply-To: <AANLkTinr1bU+_YCTW9xyJ9H0qiSOifBMsxC6iujszMvs@mail.gmail.com>
It looks to me like the change which introduced "virtual functions"
forgot about cross-platform endianness. Can anyone please test this patch?
Thank you to Arnaud for supplying before+after data files do_mounts*.o.
recordmcount: Honor endianness in fn_ELF_R_INFO
---
scripts/recordmcount.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/scripts/recordmcount.h b/scripts/recordmcount.h
index 58e933a..3966717 100644
--- a/scripts/recordmcount.h
+++ b/scripts/recordmcount.h
@@ -119,7 +119,7 @@ static uint_t (*Elf_r_sym)(Elf_Rel const *rp) = fn_ELF_R_SYM;
static void fn_ELF_R_INFO(Elf_Rel *const rp, unsigned sym, unsigned type)
{
- rp->r_info = ELF_R_INFO(sym, type);
+ rp->r_info = _w(ELF_R_INFO(sym, type));
}
static void (*Elf_r_info)(Elf_Rel *const rp, unsigned sym, unsigned type) = fn_ELF_R_INFO;
-- 1.7.3.2
--
next prev parent reply other threads:[~2010-11-23 3:42 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-22 3:04 Build failure triggered by recordmcount Arnaud Lacombe
2010-11-22 11:42 ` wu zhangjin
2010-11-22 14:57 ` wu zhangjin
2010-11-22 15:00 ` wu zhangjin
2010-11-22 15:00 ` wu zhangjin
2010-11-22 18:46 ` Arnaud Lacombe
2010-11-23 3:41 ` John Reiser [this message]
2010-11-23 4:56 ` wu zhangjin
2010-11-23 17:09 ` Steven Rostedt
2010-11-23 20:09 ` Arnaud Lacombe
2010-12-01 13:47 ` Ralf Baechle
2010-11-24 9:26 ` wu zhangjin
2010-12-02 4:54 ` Arnaud Lacombe
2010-12-02 12:01 ` Sergei Shtylyov
2010-12-02 12:41 ` Steven Rostedt
2010-12-02 14:38 ` John Reiser
2010-11-23 5:20 ` wu zhangjin
2010-12-02 14:54 ` Ralf Baechle
2010-12-02 15:18 ` Steven Rostedt
2010-12-02 15:15 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CEB37F8.1050504@bitwagon.com \
--to=jreiser@bitwagon.com \
--cc=lacombar@gmail.com \
--cc=linux-mips@linux-mips.org \
--cc=rostedt@goodmis.org \
--cc=wuzhangjin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox