From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Mon, 17 Jan 2011 20:19:16 +0100 (CET) Received: from mail3.caviumnetworks.com ([12.108.191.235]:18862 "EHLO mail3.caviumnetworks.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S1493555Ab1AQTTN (ORCPT ); Mon, 17 Jan 2011 20:19:13 +0100 Received: from caexch01.caveonetworks.com (Not Verified[192.168.16.9]) by mail3.caviumnetworks.com with MailMarshal (v6,7,2,8378) id ; Mon, 17 Jan 2011 11:19:47 -0800 Received: from caexch01.caveonetworks.com ([192.168.16.9]) by caexch01.caveonetworks.com with Microsoft SMTPSVC(6.0.3790.4675); Mon, 17 Jan 2011 11:18:58 -0800 Received: from dd1.caveonetworks.com ([12.108.191.236]) by caexch01.caveonetworks.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Mon, 17 Jan 2011 11:18:58 -0800 Message-ID: <4D349621.1040603@caviumnetworks.com> Date: Mon, 17 Jan 2011 11:18:57 -0800 From: David Daney User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.15) Gecko/20101027 Fedora/3.0.10-1.fc12 Thunderbird/3.0.10 MIME-Version: 1.0 To: Peter Zijlstra CC: Richard Henderson , Ivan Kokshaysky , Matt Turner , Russell King , Mike Frysinger , Mikael Starvik , Jesper Nilsson , Tony Luck , Fenghua Yu , Hirokazu Takata , Ralf Baechle , David Howells , Koichi Yasutake , Kyle McMartin , Helge Deller , "James E.J. Bottomley" , Benjamin Herrenschmidt , Paul Mackerras , Martin Schwidefsky , Heiko Carstens , linux390@de.ibm.com, Paul Mundt , "David S. Miller" , Chris Metcalf , Jeff Dike , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, Jeremy Fitzhardinge , Konrad Rzeszutek Wilk , linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, uclinux-dist-devel@blackfin.uclinux.org, linux-cris-kernel@axis.com, linux-ia64@vger.kernel.org, linux-m32r@ml.linux-m32r.org, linux-m32r-ja@ml.linux-m32r.org, linux-mips@linux-mips.org, linux-am33-list@redhat.com, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, user-mode-linux-devel@lists.sourceforge.net, user-mode-linux-user@lists.sourceforge.net, xen-devel@lists.xensource.com, virtualization@lists.osdl.org, Linux-Arch Subject: Re: [PATCH] sched: provide scheduler_ipi() callback in response to smp_send_reschedule() References: <1295262433.30950.53.camel@laptop> In-Reply-To: <1295262433.30950.53.camel@laptop> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 17 Jan 2011 19:18:58.0314 (UTC) FILETIME=[63E166A0:01CBB67B] Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 28946 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: ddaney@caviumnetworks.com Precedence: bulk X-list: linux-mips On 01/17/2011 03:07 AM, Peter Zijlstra wrote: > For future rework of try_to_wake_up() we'd like to push part of that > onto the CPU the task is actually going to run on, in order to do so we > need a generic callback from the existing scheduler IPI. > > This patch introduces such a generic callback: scheduler_ipi() and > implements it as a NOP. > > I visited existing smp_send_reschedule() implementations and tried to > add a call to scheduler_ipi() in their handler part, but esp. for MIPS > I'm not quite sure I actually got all of them. > > Also, while reading through all this, I noticed the blackfin SMP code > looks to be broken, it simply discards any IPI when low on memory. > > Signed-off-by: Peter Zijlstra > --- > arch/alpha/kernel/smp.c | 1 + > arch/arm/kernel/smp.c | 1 + > arch/blackfin/mach-common/smp.c | 3 ++- > arch/cris/arch-v32/kernel/smp.c | 13 ++++++++----- > arch/ia64/kernel/irq_ia64.c | 2 ++ > arch/ia64/xen/irq_xen.c | 10 +++++++++- > arch/m32r/kernel/smp.c | 2 +- > arch/mips/kernel/smtc.c | 1 + > arch/mips/sibyte/bcm1480/smp.c | 7 +++---- > arch/mips/sibyte/sb1250/smp.c | 7 +++---- [...] Peter, You will also have to patch the mailbox_interrupt() function in arch/mips/cavium-octeon/smp.c David Daney.