From: Matthieu CASTET <matthieu.castet@parrot.com>
To: Anoop P.A <anoop.pa@gmail.com>
Cc: "gregkh@suse.de" <gregkh@suse.de>,
"dbrownell@users.sourceforge.net"
<dbrownell@users.sourceforge.net>, "ust@denx.de" <ust@denx.de>,
"pkondeti@codeaurora.org" <pkondeti@codeaurora.org>,
"stern@rowland.harvard.edu" <stern@rowland.harvard.edu>,
"gadiyar@ti.com" <gadiyar@ti.com>,
"alek.du@intel.com" <alek.du@intel.com>,
"jacob.jun.pan@intel.com" <jacob.jun.pan@intel.com>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mips@linux-mips.org" <linux-mips@linux-mips.org>,
"ralf@linux-mips.org" <ralf@linux-mips.org>
Subject: Re: [PATCH v3] EHCI bus glue for on-chip PMC MSP USB controller.
Date: Wed, 9 Feb 2011 16:10:54 +0100 [thread overview]
Message-ID: <4D52AE7E.8000907@parrot.com> (raw)
In-Reply-To: <1296127736-28208-1-git-send-email-anoop.pa@gmail.com>
Anoop P.A a écrit :
> config XPS_USB_HCD_XILINX
> diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c
> index 6fee3cd..a591890 100644
> --- a/drivers/usb/host/ehci-hcd.c
> +++ b/drivers/usb/host/ehci-hcd.c
> @@ -262,6 +262,8 @@ static void tdi_reset (struct ehci_hcd *ehci)
> if (ehci_big_endian_mmio(ehci))
> tmp |= USBMODE_BE;
> ehci_writel(ehci, tmp, reg_ptr);
> + if (ehci->pmc_msp_tdi)
> + usb_hcd_tdi_set_mode(ehci);
> }
This is ugly to add callback to your driver here.
How this will build on other platform, usb_hcd_tdi_set_mode is only
defined on ehci-pmcmsp.c
> +void usb_hcd_tdi_set_mode(struct ehci_hcd *ehci)
> +{
> + u8 *base;
> + u8 *statreg;
> + u8 *fiforeg;
> + u32 val;
> + struct ehci_regs *reg_base = ehci->regs;
> +
> + /* get register base */
> + base = (u8 *)reg_base + USB_EHCI_REG_USB_MODE;
> + statreg = (u8 *)reg_base + USB_EHCI_REG_USB_STATUS;
> + fiforeg = (u8 *)reg_base + USB_EHCI_REG_USB_FIFO;
> +
> + /* set the controller to host mode and BIG ENDIAN */
> + ehci_writel(ehci, (USB_CTRL_MODE_HOST | USB_CTRL_MODE_BIG_ENDIAN
> + | USB_CTRL_MODE_STREAM_DISABLE), (u32 *)base);
> +
We have done that in tdi_reset, why do you do it again ?
Matthieu
next prev parent reply other threads:[~2011-02-09 15:11 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-21 11:06 [PATCH] EHCI support for on-chip PMC MSP USB controller Anoop P
2010-12-21 16:00 ` Alan Stern
2010-12-21 16:00 ` Alan Stern
2010-12-21 17:59 ` Greg KH
2010-12-22 14:34 ` [PATCH V2 0/2] " Anoop P.A
2010-12-22 14:36 ` [PATCH V2 1/2] " Anoop P.A
2010-12-22 14:58 ` Anoop P A
2010-12-24 9:44 ` Shane McDonald
2011-01-27 11:28 ` [PATCH v3] EHCI bus glue " Anoop P.A
2011-02-04 19:56 ` Greg KH
2011-02-09 14:12 ` Anoop P A
2011-02-09 17:20 ` Greg KH
2011-02-09 15:10 ` Matthieu CASTET [this message]
2011-02-09 15:44 ` Anoop P A
2011-02-15 10:43 ` [PATCH v4] " Anoop P.A
2011-02-15 17:44 ` Matthieu CASTET
2011-02-22 15:35 ` [PATCH v5] " Anoop P.A
2011-02-22 15:35 ` Anoop P.A
2011-02-22 20:04 ` Dan Carpenter
2011-02-22 20:04 ` Dan Carpenter
2011-02-23 13:22 ` Anoop P A
2011-02-23 13:22 ` Anoop P A
2011-02-23 17:02 ` Dan Carpenter
2011-02-23 17:02 ` Dan Carpenter
2011-02-24 10:19 ` Anoop P A
2011-02-24 10:19 ` Anoop P A
2011-02-24 11:28 ` Dan Carpenter
2011-02-24 11:28 ` Dan Carpenter
2011-02-24 13:56 ` [PATCH] " Anoop P.A
2011-02-24 13:56 ` Anoop P.A
2010-12-22 14:36 ` [PATCH V2 2/2] MSP onchip root hub over current quirk Anoop P.A
2010-12-23 2:18 ` Alan Stern
2010-12-23 2:18 ` Alan Stern
2010-12-23 9:29 ` Anoop P A
2010-12-23 16:08 ` Alan Stern
2010-12-23 16:08 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D52AE7E.8000907@parrot.com \
--to=matthieu.castet@parrot.com \
--cc=alek.du@intel.com \
--cc=anoop.pa@gmail.com \
--cc=dbrownell@users.sourceforge.net \
--cc=gadiyar@ti.com \
--cc=gregkh@suse.de \
--cc=jacob.jun.pan@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-usb@vger.kernel.org \
--cc=pkondeti@codeaurora.org \
--cc=ralf@linux-mips.org \
--cc=stern@rowland.harvard.edu \
--cc=ust@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox