From: Sergei Shtylyov <sshtylyov@mvista.com>
To: Manuel Lauss <manuel.lauss@googlemail.com>
Cc: Linux-MIPS <linux-mips@linux-mips.org>
Subject: Re: [PATCH] MIPS: DB1200: Set Config_OD for improved stability.
Date: Thu, 10 Feb 2011 21:25:37 +0300 [thread overview]
Message-ID: <4D542DA1.5020705@mvista.com> (raw)
In-Reply-To: <4D542B1D.1060407@mvista.com>
I wrote:
>> Setting Config_OD gets rid of a _LOT_ of spurious CPLD interrupts,
>> but also decreases overall performance a bit.
>> Signed-off-by: Manuel Lauss <manuel.lauss@googlemail.com>
> [...]
>> diff --git a/arch/mips/alchemy/devboards/db1200/setup.c
>> b/arch/mips/alchemy/devboards/db1200/setup.c
>> index 8876195..a3729c9 100644
>> --- a/arch/mips/alchemy/devboards/db1200/setup.c
>> +++ b/arch/mips/alchemy/devboards/db1200/setup.c
>> @@ -23,6 +23,13 @@ void __init board_setup(void)
>> unsigned long freq0, clksrc, div, pfc;
>> unsigned short whoami;
>>
>> + /* Set Config_OD (disable overlapping bus transaction):
> The bit is called Config[OD] by other Alchemy code.
> You just should add your Au1200 revision to
> au1xxx_cpu_needs_config_od() in <asm/mach-au1x00.h> so that
> plat_mem_setup() automatically sets the bit (just after it calls
> board_setup()); Au1200 rev. AC should have it set already...
Forgot to add that if you don't do it, the code in plat_mem_setup() will
clear the bit after you've set it.
WBR, Sergei
next prev parent reply other threads:[~2011-02-10 18:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-10 14:17 [PATCH RESEND] MIPS: Alchemy: update inlinable GPIO API Manuel Lauss
2011-02-10 14:17 ` [PATCH] MIPS: DB1200: Set Config_OD for improved stability Manuel Lauss
2011-02-10 18:14 ` Sergei Shtylyov
2011-02-10 18:25 ` Sergei Shtylyov [this message]
2011-02-10 14:17 ` [PATCH] Alchemy: irq: replace au_readl/writel accessors Manuel Lauss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D542DA1.5020705@mvista.com \
--to=sshtylyov@mvista.com \
--cc=linux-mips@linux-mips.org \
--cc=manuel.lauss@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox