From: Sergei Shtylyov <sshtylyov@mvista.com>
To: "Anoop P.A" <anoop.pa@gmail.com>
Cc: ralf@linux-mips.org, linux-mips@linux-mips.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Make msp7120_reset generic
Date: Sun, 20 Feb 2011 15:38:18 +0300 [thread overview]
Message-ID: <4D610B3A.5070705@mvista.com> (raw)
In-Reply-To: <1298037329-13683-1-git-send-email-anoop.pa@gmail.com>
Hello.
On 18-02-2011 16:55, Anoop P.A wrote:
> From: Anoop P A<anoop.pa@gmail.com>
> Remove platform dependency code from msp7120 reset code and make it generic.
> Now the code can be reused for other boards running msp71xx family SoC.
> Signed-off-by: Anoop P A<anoop.pa@gmail.com>
[...]
> diff --git a/arch/mips/pmc-sierra/msp71xx/msp_setup.c b/arch/mips/pmc-sierra/msp71xx/msp_setup.c
> index fb37a10..4a6cc0d 100644
> --- a/arch/mips/pmc-sierra/msp71xx/msp_setup.c
> +++ b/arch/mips/pmc-sierra/msp71xx/msp_setup.c
> @@ -18,30 +18,33 @@
>
> #include<msp_prom.h>
> #include<msp_regs.h>
> +#include<msp_gpio_macros.h>
>
> #if defined(CONFIG_PMC_MSP7120_GW)
> -#include<msp_regops.h>
> + /* GPIO 9 is the 4th GPIO of register 3
> + */
Not clear why you're using a multi-line comment where a single-one line
one (and not indented) would be enough?
> @@ -78,49 +81,56 @@ void msp7120_reset(void)
> /* Wait a bit for the DDRC to settle */
> for (i = 0; i < 100000000; i++);
>
> -#if defined(CONFIG_PMC_MSP7120_GW)
> +#if defined MSP_BOARD_RESET_GPIO
Hm, didn't know that the 'defined' syntax without parens is valid too...
> @@ -141,9 +151,7 @@ void msp_power_off(void)
>
> void __init plat_mem_setup(void)
> {
> - _machine_restart = msp_restart;
> - _machine_halt = msp_halt;
> - pm_power_off = msp_power_off;
> +/*TODO: Move mem setup here */
This line should be indented.
WBR, Sergei
next prev parent reply other threads:[~2011-02-20 12:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-18 13:55 [PATCH] Make msp7120_reset generic Anoop P.A
2011-02-20 12:38 ` Sergei Shtylyov [this message]
2011-02-22 6:41 ` [PATCH resend] " Anoop P.A
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D610B3A.5070705@mvista.com \
--to=sshtylyov@mvista.com \
--cc=anoop.pa@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox