Linux MIPS Architecture development
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sshtylyov@mvista.com>
To: Heiher <admin@heiher.info>
Cc: linux-mips@linux-mips.org
Subject: Re: [PATCH] Fixup personality in different ABI.
Date: Fri, 18 Mar 2011 13:16:48 +0300	[thread overview]
Message-ID: <4D833110.8020306@mvista.com> (raw)
In-Reply-To: <AANLkTimsVcPtJHrV+UMcXAMcqDRpm3ZbbXqSuupx0Uq5@mail.gmail.com>

Hello.

On 18-03-2011 7:59, Heiher wrote:

> Hello,

>  From bf3637153bc5e3d0e3f1c2982c323057a8e04801 Mon Sep 17 00:00:00 2001
> From: Heiher<admin@heiher.info>
> Date: Fri, 18 Mar 2011 12:51:08 +0800
> Subject: [PATCH] Fixup personality in different ABI.

    This header (and "Hello") should be omitted, or the maintainer will have 
to hand edit it out of the patch...

> * 'arch' output:
> 	o32 : mips
> 	n32 : mips64
> 	64  : mips64

    You should sign off the patch (with your real name) for it to be applied.

> diff --git a/arch/mips/include/asm/elf.h b/arch/mips/include/asm/elf.h
> index 455c0ac..01510d4 100644
> --- a/arch/mips/include/asm/elf.h
> +++ b/arch/mips/include/asm/elf.h
[...]
> @@ -305,7 +307,10 @@ do {									\
>   	if ((ex).e_ident[EI_CLASS] == ELFCLASS32)			\
>   		__SET_PERSONALITY32(ex);				\
>   	else								\
> +	{								\

    { should be on the same line with *else*.

WBR, Sergei

  reply	other threads:[~2011-03-18 10:18 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-18  4:59 [PATCH] Fixup personality in different ABI Heiher
2011-03-18 10:16 ` Sergei Shtylyov [this message]
2011-03-18 16:17 ` David Daney
2011-03-18 16:34   ` Heiher
2011-03-18 16:57     ` David Daney
2011-03-18 18:18 ` Ralf Baechle
     [not found] <AANLkTikuBxnd0bFsO5NP2GQYDZmGFP9kLruWVpjZ7+UQ@mail.gmail.com>
2011-03-24 12:03 ` Ralf Baechle
  -- strict thread matches above, loose matches on Subject: below --
2011-03-18  4:51 Heiher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D833110.8020306@mvista.com \
    --to=sshtylyov@mvista.com \
    --cc=admin@heiher.info \
    --cc=linux-mips@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox