From: John Crispin <john@phrozen.org>
To: dedekind1@gmail.com
Cc: Ralf Baechle <ralf@linux-mips.org>,
linux-mips@linux-mips.org, Ralph Hempel <ralph.hempel@lantiq.com>,
linux-mtd@lists.infradead.org,
Daniel Schwierzeck <daniel.schwierzeck@googlemail.com>,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH V2 06/10] MIPS: lantiq: add NOR flash support
Date: Mon, 28 Mar 2011 16:15:28 +0200 [thread overview]
Message-ID: <4D909800.50701@phrozen.org> (raw)
In-Reply-To: <4D74CEC2.4040506@openwrt.org>
On 07/03/11 13:25, John Crispin wrote:
> On 07/03/11 09:58, Artem Bityutskiy wrote:
>> On Tue, 2011-03-01 at 17:13 +0100, John Crispin wrote:
>>
>>> NOR flash is attached to the same EBU (External Bus Unit) as PCI. As described
>>> in the PCI patch, the EBU is a little buggy, resulting in the upper and lower
>>> 16 bit of the data on a 32 bit read are swapped. (essentially we have a addr^=2)
>>>
>>> To work around this we do a addr^=2 during the probe. Once probed we adapt
>>> cfi->addr_unlock1 and cfi->addr_unlock2 to represent the endianess bug.
>>>
>>> Changes in V2
>>> * handle the endianess bug inside the map code and not in the generic cfi code
>>> * remove the addr swizzle patch
>>>
>>> Signed-off-by: John Crispin <blogic@openwrt.org>
>>> Signed-off-by: Ralph Hempel <ralph.hempel@lantiq.com>
>>> Cc: David Woodhouse <dwmw2@infradead.org>
>>> Cc: Daniel Schwierzeck <daniel.schwierzeck@googlemail.com>
>>> Cc: linux-mips@linux-mips.org
>>> Cc: linux-mtd@lists.infradead.org
>>>
>> There are a couple checkpatch.pl warnings, would you please address them
>> and resend?
>>
>>
> Hi,
>
> of course.
>
> thanks,
> John
>
>
Hi,
i fixed one of the warnings. the remaining warning wants me to put at
least 4 lines into the help section in the Kconfig. However 3 lines were
enough to explain what the driver does.
John
next prev parent reply other threads:[~2011-03-28 14:13 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-01 16:13 [PATCH V2 00/10] MIPS: add support for Lantiq SoCs John Crispin
2011-03-01 16:13 ` [PATCH V2 01/10] MIPS: lantiq: add initial " John Crispin
2011-03-01 16:13 ` [PATCH V2 02/10] MIPS: lantiq: add SoC specific code for XWAY family John Crispin
2011-03-01 16:13 ` [PATCH V2 03/10] MIPS: lantiq: add PCI controller support John Crispin
2011-03-01 16:13 ` [PATCH V2 04/10] MIPS: lantiq: add serial port support John Crispin
2011-03-01 16:13 ` [PATCH V2 05/10] MIPS: lantiq: add watchdog support John Crispin
2011-03-02 11:22 ` Sergei Shtylyov
2011-03-02 14:29 ` Ralf Baechle
2011-03-02 15:05 ` John Crispin
2011-03-02 16:27 ` Ralf Baechle
2011-03-02 17:36 ` Sergei Shtylyov
2011-03-02 17:34 ` Sergei Shtylyov
2011-03-02 15:44 ` John Crispin
2011-03-03 10:15 ` Jamie Iles
2011-03-03 11:21 ` Sergei Shtylyov
2011-03-01 16:13 ` [PATCH V2 06/10] MIPS: lantiq: add NOR flash support John Crispin
2011-03-07 8:58 ` Artem Bityutskiy
2011-03-07 12:25 ` John Crispin
2011-03-28 14:15 ` John Crispin [this message]
2011-03-01 16:13 ` [PATCH V2 07/10] MIPS: lantiq: add platform device support John Crispin
2011-03-01 16:13 ` [PATCH V2 08/10] MIPS: lantiq: add mips_machine support John Crispin
2011-03-01 16:13 ` [PATCH V2 09/10] MIPS: lantiq: add machtypes for lantiq eval kits John Crispin
2011-03-01 16:13 ` [PATCH V2 10/10] MIPS: lantiq: add more gpio drivers John Crispin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D909800.50701@phrozen.org \
--to=john@phrozen.org \
--cc=daniel.schwierzeck@googlemail.com \
--cc=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-mtd@lists.infradead.org \
--cc=ralf@linux-mips.org \
--cc=ralph.hempel@lantiq.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox