From: David Daney <ddaney@caviumnetworks.com>
To: John Crispin <blogic@openwrt.org>
Cc: Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org
Subject: Re: [PATCH 1/3] MIPS: lantiq: Add missing include to mach-easy50712.c
Date: Thu, 12 May 2011 10:09:36 -0700 [thread overview]
Message-ID: <4DCC1450.6060006@caviumnetworks.com> (raw)
In-Reply-To: <4DCB76E5.3070703@openwrt.org>
On 05/11/2011 10:57 PM, John Crispin wrote:
> On 11/05/11 23:25, Ralf Baechle wrote:
>> Thanks, folded into "MIPS: Lantiq: Add etop board support".
>>
>> Ralf
>>
>>
>
> Hi,
>
> the include should be in arch/lantiq/devices.h and not the mach-*.c file.
>
It is best to keep the include pushed as far to the leaves of the build
as possible. That makes compiling other files that need devices.h faster.
> this got lost int he folding and i thought we fixed it yesterday already .
In any event I think Ralf has it sorted out now. linux-queue is now
building for me with no patches.
David Daney
next prev parent reply other threads:[~2011-05-12 17:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-11 20:22 [PATCH 0/3] MIPS: lantiq: Fix build problems on linux-queue David Daney
2011-05-11 20:22 ` [PATCH 1/3] MIPS: lantiq: Add missing include to mach-easy50712.c David Daney
2011-05-11 21:25 ` Ralf Baechle
2011-05-12 5:57 ` John Crispin
2011-05-12 17:09 ` David Daney [this message]
2011-05-12 17:15 ` John Crispin
2011-05-11 20:22 ` [PATCH 2/3] MIPS: lantiq: Fix section mismatch in gpio_stp.c David Daney
2011-05-11 22:49 ` Ralf Baechle
2011-05-11 20:22 ` [PATCH 3/3] MIPS: lantiq: Check return value from strict_strtoul() David Daney
2011-05-11 22:53 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DCC1450.6060006@caviumnetworks.com \
--to=ddaney@caviumnetworks.com \
--cc=blogic@openwrt.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox