From: Sergei Shtylyov <sshtylyov@mvista.com>
To: Gabor Juhos <juhosg@openwrt.org>
Cc: Ralf Baechle <ralf@linux-mips.org>,
linux-mips@linux-mips.org, Kathy Giori <kgiori@qca.qualcomm.com>,
"Luis R. Rodriguez" <rodrigue@qca.qualcomm.com>
Subject: Re: [PATCH 02/13] MIPS: ath79: add revision id for the AR933X SoCs
Date: Tue, 21 Jun 2011 14:22:02 +0400 [thread overview]
Message-ID: <4E0070CA.1070102@mvista.com> (raw)
In-Reply-To: <1308597973-6037-3-git-send-email-juhosg@openwrt.org>
Hello.
On 20-06-2011 23:26, Gabor Juhos wrote:
> Signed-off-by: Gabor Juhos<juhosg@openwrt.org>
> ---
> arch/mips/ath79/setup.c | 12 ++++++++++++
> arch/mips/include/asm/mach-ath79/ar71xx_regs.h | 4 ++++
> arch/mips/include/asm/mach-ath79/ath79.h | 4 +++-
> 3 files changed, 19 insertions(+), 1 deletions(-)
> diff --git a/arch/mips/ath79/setup.c b/arch/mips/ath79/setup.c
> index dea5af1..4cbd5e0 100644
> --- a/arch/mips/ath79/setup.c
> +++ b/arch/mips/ath79/setup.c
> @@ -116,6 +116,18 @@ static void __init ath79_detect_sys_type(void)
> rev = id& AR724X_REV_ID_REVISION_MASK;
> break;
>
> + case REV_ID_MAJOR_AR9330:
> + ath79_soc = ATH79_SOC_AR9330;
> + chip = "9330";
> + rev = (id & AR933X_REV_ID_REVISION_MASK);
> + break;
> +
> + case REV_ID_MAJOR_AR9331:
> + ath79_soc = ATH79_SOC_AR9331;
> + chip = "9331";
> + rev = (id & AR933X_REV_ID_REVISION_MASK);
Hm, you've just removed such parens in the previous patch, why add more of
them? :-O
WBR, Sergei
next prev parent reply other threads:[~2011-06-21 10:23 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-20 19:26 [PATCH 00/13] MIPS: ath79: add initial support for AR933X SoCs Gabor Juhos
2011-06-20 19:26 ` [PATCH 01/13] MIPS: ath79: remove superfluous parentheses Gabor Juhos
2011-11-16 19:10 ` Ralf Baechle
2011-06-20 19:26 ` [PATCH 02/13] MIPS: ath79: add revision id for the AR933X SoCs Gabor Juhos
2011-06-21 10:22 ` Sergei Shtylyov [this message]
2011-06-21 18:17 ` Gabor Juhos
2011-11-16 19:11 ` Ralf Baechle
2011-06-20 19:26 ` [PATCH 03/13] MIPS: ath79: add early printk support " Gabor Juhos
2011-11-16 19:11 ` Ralf Baechle
2011-06-20 19:26 ` [PATCH 04/13] MIPS: ath79: add AR933X specific clock init Gabor Juhos
2011-11-16 19:11 ` Ralf Baechle
2011-06-20 19:26 ` [PATCH 05/13] MIPS: ath79: add AR933X specific glue for ath79_device_reset_{set,clear} Gabor Juhos
2011-11-16 19:11 ` Ralf Baechle
2011-06-20 19:26 ` [PATCH 06/13] MIPS: ath79: add AR933X specific IRQ initialization Gabor Juhos
2011-11-16 19:11 ` Ralf Baechle
2011-06-20 19:26 ` [PATCH 07/13] MIPS: ath79: add AR933X specific GPIO initialization Gabor Juhos
2011-11-16 19:11 ` Ralf Baechle
2011-06-20 19:26 ` [PATCH 08/13] MIPS: ath79: add config symbol for the AR933X SoCs Gabor Juhos
2011-11-16 19:12 ` Ralf Baechle
2011-06-20 19:26 ` [PATCH 09/13] USB: ehci-ath79: add device_id entry " Gabor Juhos
2011-11-16 19:13 ` Ralf Baechle
2011-06-20 19:26 ` [PATCH 10/13] MIPS: ath79: add AR933X specific USB platform device registration Gabor Juhos
2011-11-16 19:13 ` Ralf Baechle
2011-06-20 19:26 ` [PATCH 11/13] serial: add driver for the built-in UART of the AR933X SoC Gabor Juhos
2011-06-21 8:59 ` Alan Cox
2011-06-21 18:55 ` Gabor Juhos
2011-07-01 21:11 ` Greg KH
2011-11-16 19:13 ` Ralf Baechle
2011-06-20 19:26 ` [PATCH 12/13] MIPS: ath79: register UART device for the AR933X SoCs Gabor Juhos
2011-11-16 19:14 ` Ralf Baechle
2011-06-20 19:26 ` [PATCH 13/13] MIPS: ath79: add initial support for the Atheros AP121 reference board Gabor Juhos
2011-11-16 19:14 ` Ralf Baechle
2011-11-16 19:18 ` [PATCH 00/13] MIPS: ath79: add initial support for AR933X SoCs Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E0070CA.1070102@mvista.com \
--to=sshtylyov@mvista.com \
--cc=juhosg@openwrt.org \
--cc=kgiori@qca.qualcomm.com \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=rodrigue@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox