From: David Daney <david.daney@cavium.com>
To: "manesoni@cisco.com" <manesoni@cisco.com>
Cc: Ralf Baechle <ralf@linux-mips.org>,
"ananth@in.ibm.com" <ananth@in.ibm.com>,
"kamensky@cisco.com" <kamensky@cisco.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mips@linux-mips.org" <linux-mips@linux-mips.org>
Subject: Re: [PATCH 1/4] MIPS Kprobes: Fix OOPS in arch_prepare_kprobe()
Date: Tue, 08 Nov 2011 11:57:45 -0800 [thread overview]
Message-ID: <4EB989B9.2060904@cavium.com> (raw)
In-Reply-To: <20111108170454.GB16526@cisco.com>
On 11/08/2011 09:04 AM, Maneesh Soni wrote:
[...]
>
> diff --git a/arch/mips/kernel/kprobes.c b/arch/mips/kernel/kprobes.c
> index ee28683..9fb1876 100644
> --- a/arch/mips/kernel/kprobes.c
> +++ b/arch/mips/kernel/kprobes.c
> @@ -25,6 +25,7 @@
>
> #include<linux/kprobes.h>
> #include<linux/preempt.h>
> +#include<linux/uaccess.h>
> #include<linux/kdebug.h>
> #include<linux/slab.h>
>
> @@ -118,11 +119,19 @@ int __kprobes arch_prepare_kprobe(struct kprobe *p)
> union mips_instruction prev_insn;
> int ret = 0;
>
> - prev_insn = p->addr[-1];
> insn = p->addr[0];
>
> - if (insn_has_delayslot(insn) || insn_has_delayslot(prev_insn)) {
> - pr_notice("Kprobes for branch and jump instructions are not supported\n");
> + if (insn_has_delayslot(insn)) {
> + pr_notice("Kprobes for branch and jump instructions are not"
> + "supported\n");
Don't wrap these strings.
It is better to go a little bit over 80 columns, than have this.
David Daney
next prev parent reply other threads:[~2011-11-08 19:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-08 17:03 [PATCH 0/4] MIPS Kprobes Maneesh Soni
2011-11-08 17:04 ` [PATCH 1/4] MIPS Kprobes: Fix OOPS in arch_prepare_kprobe() Maneesh Soni
2011-11-08 19:57 ` David Daney [this message]
2011-11-09 5:26 ` Maneesh Soni
2011-11-17 23:17 ` Ralf Baechle
2011-11-08 17:05 ` [PATCH 2/4] MIPS Kprobes: Deny probes on ll/sc instructions Maneesh Soni
2011-11-08 20:01 ` David Daney
2011-11-08 23:26 ` Victor Kamensky
2011-11-16 12:12 ` Ralf Baechle
2011-11-16 17:39 ` Victor Kamensky
2011-11-17 23:18 ` Ralf Baechle
2011-11-08 17:07 ` [PATCH 3/4] MIPS Kprobes: Refactoring Branch emulation Maneesh Soni
2011-11-17 23:18 ` Ralf Baechle
2011-11-08 17:08 ` [PATCH 4/4] MIPS Kprobes: Support branch instructions probing - v2 Maneesh Soni
2011-11-17 23:18 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EB989B9.2060904@cavium.com \
--to=david.daney@cavium.com \
--cc=ananth@in.ibm.com \
--cc=kamensky@cisco.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=manesoni@cisco.com \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox