From: John Crispin <john@phrozen.org>
To: Ralf Baechle <ralf@linux-mips.org>
Cc: linux-mips@linux-mips.org
Subject: Re: [PATCH] MIPS: lantiq: Fix compile error in arch/mips/lantiq/xway/dma.c
Date: Thu, 10 Nov 2011 16:42:18 +0100 [thread overview]
Message-ID: <4EBBF0DA.3090602@phrozen.org> (raw)
In-Reply-To: <1320938762-3472-1-git-send-email-blogic@openwrt.org>
Hi Ralf,
please ignore this patch, i will resend a different version that
replaces module.h with export.h
for all arch/mips/lantiq/ files.
thanks,
John
On 10/11/11 16:26, John Crispin wrote:
> include/export.h needs to be included by arch/mips/lantiq/xway/dma.c.
> Without this include we see the following errors.
>
> arch/mips/lantiq/xway/dma.c:76:1: error: data definition has no type or storage class
> arch/mips/lantiq/xway/dma.c:76:1: error: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
> arch/mips/lantiq/xway/dma.c:76:1: error: parameter names (without types) in function declaration
> arch/mips/lantiq/xway/dma.c:88:1: error: data definition has no type or storage class
> arch/mips/lantiq/xway/dma.c:88:1: error: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
> arch/mips/lantiq/xway/dma.c:88:1: error: parameter names (without types) in function declaration
> arch/mips/lantiq/xway/dma.c:100:1: error: data definition has no type or storage class
> arch/mips/lantiq/xway/dma.c:100:1: error: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
> arch/mips/lantiq/xway/dma.c:100:1: error: parameter names (without types) in function declaration
> arch/mips/lantiq/xway/dma.c:113:1: error: data definition has no type or storage class
> arch/mips/lantiq/xway/dma.c:113:1: error: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
> arch/mips/lantiq/xway/dma.c:113:1: error: parameter names (without types) in function declaration
> arch/mips/lantiq/xway/dma.c:126:1: error: data definition has no type or storage class
> arch/mips/lantiq/xway/dma.c:126:1: error: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
> arch/mips/lantiq/xway/dma.c:126:1: error: parameter names (without types) in function declaration
> arch/mips/lantiq/xway/dma.c:164:1: error: data definition has no type or storage class
> arch/mips/lantiq/xway/dma.c:164:1: error: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
> arch/mips/lantiq/xway/dma.c:164:1: error: parameter names (without types) in function declaration
> arch/mips/lantiq/xway/dma.c:179:1: error: data definition has no type or storage class
> arch/mips/lantiq/xway/dma.c:179:1: error: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
> arch/mips/lantiq/xway/dma.c:179:1: error: parameter names (without types) in function declaration
> arch/mips/lantiq/xway/dma.c:190:1: error: data definition has no type or storage class
> arch/mips/lantiq/xway/dma.c:190:1: error: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
> arch/mips/lantiq/xway/dma.c:190:1: error: parameter names (without types) in function declaration
> arch/mips/lantiq/xway/dma.c:215:1: error: data definition has no type or storage class
> arch/mips/lantiq/xway/dma.c:215:1: error: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
> arch/mips/lantiq/xway/dma.c:215:1: error: parameter names (without types) in function declaration
>
> Signed-off-by: John Crispin <blogic@openwrt.org>
> Cc: linux-mips@linux-mips.org
>
> ---
> arch/mips/lantiq/xway/dma.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/arch/mips/lantiq/xway/dma.c b/arch/mips/lantiq/xway/dma.c
> index 4278a45..cbb6ae5 100644
> --- a/arch/mips/lantiq/xway/dma.c
> +++ b/arch/mips/lantiq/xway/dma.c
> @@ -19,6 +19,7 @@
> #include <linux/platform_device.h>
> #include <linux/io.h>
> #include <linux/dma-mapping.h>
> +#include <linux/export.h>
>
> #include <lantiq_soc.h>
> #include <xway_dma.h>
prev parent reply other threads:[~2011-11-10 14:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-10 15:26 [PATCH] MIPS: lantiq: Fix compile error in arch/mips/lantiq/xway/dma.c John Crispin
2011-11-10 15:42 ` John Crispin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EBBF0DA.3090602@phrozen.org \
--to=john@phrozen.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox