From: David Daney <ddaney@caviumnetworks.com>
To: Sergei Shtylyov <sshtylyov@mvista.com>
Cc: David Daney <ddaney.cavm@gmail.com>,
"linux-mips@linux-mips.org" <linux-mips@linux-mips.org>,
"ralf@linux-mips.org" <ralf@linux-mips.org>,
David Daney <david.daney@cavium.com>
Subject: Re: [PATCH] MIPS: Get rid of some #ifdefery in arch/mips/mm/tlb-r4k.c
Date: Mon, 21 Nov 2011 10:16:08 -0800 [thread overview]
Message-ID: <4ECA9568.2000601@caviumnetworks.com> (raw)
In-Reply-To: <4ECA2869.2000404@mvista.com>
On 11/21/2011 02:31 AM, Sergei Shtylyov wrote:
> Hello.
>
> On 19-11-2011 1:30, David Daney wrote:
>
>> From: David Daney<david.daney@cavium.com>
>
>> In the case of !CONFIG_HUGETLB_PAGE, in linux/hugetlb.h we have this
>> definition:
>
> Missed it?
Indeed, I could swear that I put '#define pmd_huge(x) 0' in that commit
log, but it is not there. The string was even still highlighted in my
editor. At this point I blame the 'git commit' command for erasing that
line.
David Daney
>
>> The other huge page constants in the if(pmd_huge()) block are likewise
>> defined, so we can get rid of the #ifdef CONFIG_HUGETLB_PAGE an let
>> the compiler optimize this block away instead. Doing this the code
>> has a much cleaner appearance.
>
>> Signed-off-by: David Daney<david.daney@cavium.com>
>
> WBR, Sergei
>
prev parent reply other threads:[~2011-11-21 18:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-18 21:30 [PATCH] MIPS: Get rid of some #ifdefery in arch/mips/mm/tlb-r4k.c David Daney
2011-11-21 10:31 ` Sergei Shtylyov
2011-11-21 18:16 ` David Daney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ECA9568.2000601@caviumnetworks.com \
--to=ddaney@caviumnetworks.com \
--cc=david.daney@cavium.com \
--cc=ddaney.cavm@gmail.com \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=sshtylyov@mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox