From: David Daney <david.daney@cavium.com>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: David Daney <ddaney.cavm@gmail.com>,
ralf@linux-mips.org,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mips@linux-mips.org,
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>,
linux-kernel@vger.kernel.org, Jason Baron <jbaron@redhat.com>
Subject: Re: [PATCH] jump-label: initialize jump-label subsystem somewhat later
Date: Wed, 14 Dec 2011 09:17:05 -0800 [thread overview]
Message-ID: <4EE8DA11.5020109@cavium.com> (raw)
In-Reply-To: <1323881470.28489.51.camel@twins>
On 12/14/2011 08:51 AM, Peter Zijlstra wrote:
> On Wed, 2011-12-14 at 08:48 -0800, David Daney wrote:
>> From: David Daney<david.daney@cavium.com>
>>
>> commit 97ce2c88f9ad42e3c60a9beb9fca87abf3639faa breaks MIPS.
>>
>> The jump-lable initialization does I-Cache flushing after modifying
>> code. On MIPS this is done by calling through the function pointer
>> flush_icache_range(). This function pointer is initialized mm_init().
Actually I misspoke, for MIPS we need jump_label_init() after
trap_init(), not mm_init().
>>
>> As things stand, we cannot be calling jump_label_init() until after
>> mm_init() completes, so we move the call down to satisfy this
>> constraint.
>
> I'm fine as long as it stays before sched_init(), which it does. Jeremy
> is this still early enough for you?
>
Just tested a revised patch that moves it to between trap_init() and
mm_init(), I propose that we do that instead.
New patch in a couple of minutes.
David Daney
next prev parent reply other threads:[~2011-12-14 17:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-14 16:48 [PATCH] jump-label: initialize jump-label subsystem somewhat later David Daney
2011-12-14 16:51 ` Peter Zijlstra
2011-12-14 17:17 ` David Daney [this message]
2011-12-14 18:31 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EE8DA11.5020109@cavium.com \
--to=david.daney@cavium.com \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=ddaney.cavm@gmail.com \
--cc=jbaron@redhat.com \
--cc=jeremy.fitzhardinge@citrix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox