From: Sergei Shtylyov <sshtylyov@mvista.com>
To: Jonas Gorski <jonas.gorski@gmail.com>
Cc: Ralf Baechle <ralf@linux-mips.org>,
linux-mips@linux-mips.org, Maxime Bizon <mbizon@freebox.fr>,
Florian Fainelli <florian@openwrt.org>
Subject: Re: [PATCH] MIPS: BCM63XX: add missing include for bcm63xx_gpio.h
Date: Fri, 03 Feb 2012 14:25:35 +0400 [thread overview]
Message-ID: <4F2BB61F.8010708@mvista.com> (raw)
In-Reply-To: <1328215931-24817-1-git-send-email-jonas.gorski@gmail.com>
Hello.
On 03-02-2012 0:52, Jonas Gorski wrote:
> bcm63xx_gpio.h uses macros defined in bcm63xx_cpu.h without including it,
> leading to the following build failure:
> CC [M] drivers/mmc/core/cd-gpio.o
> In file included from arch/mips/include/asm/mach-bcm63xx/gpio.h:4:0,
> from arch/mips/include/asm/gpio.h:4,
> from include/linux/gpio.h:30,
> from drivers/mmc/core/cd-gpio.c:12:
> arch/mips/include/asm/mach-bcm63xx/bcm63xx_gpio.h: In function 'bcm63xx_gpio_count':
> arch/mips/include/asm/mach-bcm63xx/bcm63xx_gpio.h:10:2: error: implicit declaration of function 'bcm63xx_get_cpu_id'
> arch/mips/include/asm/mach-bcm63xx/bcm63xx_gpio.h:11:7: error: 'BCM6358_CPU_ID' undeclared (first use in this function)
> arch/mips/include/asm/mach-bcm63xx/bcm63xx_gpio.h:11:7: note: each undeclared identifier is reported only once for each function it appears in
> arch/mips/include/asm/mach-bcm63xx/bcm63xx_gpio.h:13:7: error: 'BCM6338_CPU_ID' undeclared (first use in this function)
> arch/mips/include/asm/mach-bcm63xx/bcm63xx_gpio.h:15:7: error: 'BCM6345_CPU_ID' undeclared (first use in this function)
> arch/mips/include/asm/mach-bcm63xx/bcm63xx_gpio.h:17:7: error: 'BCM6368_CPU_ID' undeclared (first use in this function)
> arch/mips/include/asm/mach-bcm63xx/bcm63xx_gpio.h:19:7: error: 'BCM6348_CPU_ID' undeclared (first use in this function)
> make[7]: *** [drivers/mmc/core/cd-gpio.o] Error 1
> Signed-off-by: Jonas Gorski<jonas.gorski@gmail.com>
> ---
> Looking at the file's history, it looks like the problem was there from
> the beginning. So it probably should go into all supported (stable)
> versions up to 3.3-rc2, even if this particular build failure popped up
> first in 3.3.
You should then addd "Cc: stable@vger.kernel.org" line after your signoff.
WBR, Sergei
next prev parent reply other threads:[~2012-02-03 10:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-02 20:52 [PATCH] MIPS: BCM63XX: add missing include for bcm63xx_gpio.h Jonas Gorski
2012-02-03 10:25 ` Sergei Shtylyov [this message]
2012-02-03 11:17 ` Jonas Gorski
2012-02-03 11:34 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F2BB61F.8010708@mvista.com \
--to=sshtylyov@mvista.com \
--cc=florian@openwrt.org \
--cc=jonas.gorski@gmail.com \
--cc=linux-mips@linux-mips.org \
--cc=mbizon@freebox.fr \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox