From: John Crispin <blogic@openwrt.org>
To: John Crispin <blogic@openwrt.org>
Cc: Ralf Baechle <ralf@linux-mips.org>,
linux-mips@linux-mips.org, netdev@vger.kernel.org
Subject: Re: [PATCH 4/6] NET: MIPS: lantiq: convert etop to managed gpio
Date: Fri, 17 Feb 2012 13:24:16 +0100 [thread overview]
Message-ID: <4F3E46F0.5010701@openwrt.org> (raw)
In-Reply-To: <1329474771-20874-5-git-send-email-blogic@openwrt.org>
> ltq_gbit_w32_mask(0, PX_CTL_DMDIO, LTQ_GBIT_P0_CTL);
> @@ -873,6 +870,12 @@ ltq_etop_probe(struct platform_device *pdev)
> err = -ENOMEM;
> goto err_out;
> }
> + if (ltq_gpio_request(&pdev->dev, 42, 2, 1, "MDIO") ||
> + ltq_gpio_request(&pdev->dev, 43, 2, 1, "MDC")) {
> + dev_err(&pdev->dev, "failed to request MDIO gpios\n");
> + err = -ENOMEM;
-EBUSY should go here instead of -ENOMEM
> + goto err_out;
> + }
> }
>
> dev = alloc_etherdev_mq(sizeof(struct ltq_etop_priv), 4);
next prev parent reply other threads:[~2012-02-17 12:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-17 10:32 [PATCH 0/6] MIPS: lantiq: use managed gpios John Crispin
2012-02-17 10:32 ` [PATCH 1/6] MIPS: lantiq: remove redunant ltq_gpio_request() declaration and add device parameter John Crispin
2012-02-17 10:32 ` [PATCH 2/6] MIPS: lantiq: use devm_request_gpio inside xway gpio driver John Crispin
2012-02-17 10:32 ` [PATCH 3/6] MIPS: lantiq: use devm_request_gpio inside falcon " John Crispin
2012-02-17 10:32 ` [PATCH 4/6] NET: MIPS: lantiq: convert etop to managed gpio John Crispin
2012-02-17 12:24 ` John Crispin [this message]
2012-02-17 10:32 ` [PATCH 5/6] MIPS: lantiq: convert pci " John Crispin
2012-02-17 10:32 ` [PATCH 6/6] MIPS: lantiq: convert gpio_stp " John Crispin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F3E46F0.5010701@openwrt.org \
--to=blogic@openwrt.org \
--cc=linux-mips@linux-mips.org \
--cc=netdev@vger.kernel.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox