From: John Crispin <blogic@openwrt.org>
To: Sergei Shtylyov <sshtylyov@mvista.com>
Cc: Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org
Subject: Re: [PATCH 2/3] MIPS: lantiq: add vr9 support
Date: Fri, 17 Feb 2012 17:50:40 +0100 [thread overview]
Message-ID: <4F3E8560.7020309@openwrt.org> (raw)
In-Reply-To: <4F3E91B5.5080603@mvista.com>
>> +#define SOC_ID_VRX288 0x1C0
>
> Use tabs to indent the value as above.
>
i would have expected checkpatch.pl to complain about this one ?!
>> + } else if (ltq_is_vr9()) {
>
> Where is this defined?
>
was added around 3.1 with the rest of the soc detection code.
you can find it in arch/mips/include/asm/mach-lantiq/xway/lantiq_soc.h
thx,
John
next prev parent reply other threads:[~2012-02-17 16:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-17 10:33 [PATCH 1/3] MIPS: lantiq: unify xway prom code John Crispin
2012-02-17 10:33 ` [PATCH 2/3] MIPS: lantiq: add vr9 support John Crispin
2012-02-17 17:43 ` Sergei Shtylyov
2012-02-17 16:50 ` John Crispin [this message]
2012-02-17 10:33 ` [PATCH 3/3] MIPS: lantiq: make use of module_platform_driver() John Crispin
2012-02-17 23:02 ` Daniel Schwierzeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F3E8560.7020309@openwrt.org \
--to=blogic@openwrt.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=sshtylyov@mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox