From: Sergei Shtylyov <sshtylyov@mvista.com>
To: John Crispin <blogic@openwrt.org>
Cc: Ralf Baechle <ralf@linux-mips.org>,
linux-mips@linux-mips.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH 7/9] SERIAL: MIPS: lantiq: convert serial driver to clkdev api
Date: Fri, 17 Feb 2012 20:39:16 +0300 [thread overview]
Message-ID: <4F3E90C4.8010904@mvista.com> (raw)
In-Reply-To: <1329474800-20979-8-git-send-email-blogic@openwrt.org>
Hello.
On 02/17/2012 01:33 PM, John Crispin wrote:
> Update from old pmu_{dis,en}able() to ckldev api.
The comment doesn't match the essence of patch.
> Signed-off-by: John Crispin<blogic@openwrt.org>
> Cc: linux-serial@vger.kernel.org
> ---
> This patch should go via MIPS with the rest of the series.
> drivers/tty/serial/lantiq.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
> diff --git a/drivers/tty/serial/lantiq.c b/drivers/tty/serial/lantiq.c
> index 96c1cac..136dae8 100644
> --- a/drivers/tty/serial/lantiq.c
> +++ b/drivers/tty/serial/lantiq.c
> @@ -686,7 +686,7 @@ lqasc_probe(struct platform_device *pdev)
> if (lqasc_port[pdev->id] != NULL)
> return -EBUSY;
>
> - clk = clk_get(&pdev->dev, "fpi");
> + clk = clk_get_sys("fpi", NULL);
Why not just clk_get(&pdev->dev, NULL)?
WBR, Sergei
next prev parent reply other threads:[~2012-02-17 16:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-17 10:33 [PATCH 0/9] MIPS: lantiq: convert to clkdev api John Crispin
2012-02-17 10:33 ` [PATCH 1/9] MIPS: add clkdev.h John Crispin
2012-02-17 10:33 ` [PATCH 2/9] MIPS: lantiq: convert to clkdev api John Crispin
2012-02-17 10:33 ` [PATCH 3/9] MIPS: lantiq: convert xway " John Crispin
2012-02-17 10:33 ` [PATCH 4/9] MIPS: lantiq: convert falcon " John Crispin
2012-02-17 10:33 ` [PATCH 5/9] MIPS: lantiq: convert dma driver " John Crispin
2012-02-17 10:33 ` [PATCH 6/9] MIPS: lantiq: convert gpio_stp " John Crispin
2012-02-17 10:33 ` [PATCH 7/9] SERIAL: MIPS: lantiq: convert serial " John Crispin
2012-02-17 17:39 ` Sergei Shtylyov [this message]
2012-02-17 16:47 ` John Crispin
2012-02-17 17:53 ` Sergei Shtylyov
2012-02-17 10:33 ` [PATCH 8/9] NET: MIPS: lantiq: convert etop " John Crispin
2012-02-17 10:33 ` [PATCH 9/9] WDT: MIPS: lantiq: convert watchdog " John Crispin
2012-02-17 17:40 ` Sergei Shtylyov
2012-02-17 16:47 ` John Crispin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F3E90C4.8010904@mvista.com \
--to=sshtylyov@mvista.com \
--cc=blogic@openwrt.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-serial@vger.kernel.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox