From: Hauke Mehrtens <hauke@hauke-m.de>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: gregkh@linuxfoundation.org, linux-mips@linux-mips.org,
ralf@linux-mips.org, m@bues.ch, linux-usb@vger.kernel.org
Subject: Re: [PATCH 6/7] USB: OHCI: remove old SSB OHCI driver
Date: Mon, 12 Mar 2012 21:50:48 +0100 [thread overview]
Message-ID: <4F5E61A8.20903@hauke-m.de> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1203121023490.1216-100000@iolanthe.rowland.org>
On 03/12/2012 03:28 PM, Alan Stern wrote:
> On Sun, 11 Mar 2012, Hauke Mehrtens wrote:
>
>> This is now replaced by the new ssb USB driver, which also supports
>> devices with an EHCI controller.
>>
>> Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
>> ---
>> drivers/usb/host/Kconfig | 13 --
>> drivers/usb/host/ohci-hcd.c | 21 +----
>> drivers/usb/host/ohci-ssb.c | 260 -------------------------------------------
>> 3 files changed, 1 insertions(+), 293 deletions(-)
>> delete mode 100644 drivers/usb/host/ohci-ssb.c
>>
>> diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
>> index eab27d5..665fb89 100644
>> --- a/drivers/usb/host/Kconfig
>> +++ b/drivers/usb/host/Kconfig
>> @@ -360,19 +360,6 @@ config USB_OHCI_HCD_PCI
>> Enables support for PCI-bus plug-in USB controller cards.
>> If unsure, say Y.
>>
>> -config USB_OHCI_HCD_SSB
>> - bool "OHCI support for Broadcom SSB OHCI core"
>> - depends on USB_OHCI_HCD && (SSB = y || SSB = USB_OHCI_HCD) && EXPERIMENTAL
>> - default n
>> - ---help---
>> - Support for the Sonics Silicon Backplane (SSB) attached
>> - Broadcom USB OHCI core.
>> -
>> - This device is present in some embedded devices with
>> - Broadcom based SSB bus.
>> -
>> - If unsure, say N.
>> -
>
> I don't like the idea of removing this section entirely. It will leave
> people wondering what happened to their driver.
>
> Instead, for the next few kernel releases, how about leaving this
> section in place and causing it to select USB_OHCI_HCD_PLATFORM? Maybe
> also add a line to the help section explaining that from now on, this
> driver has been replaced by the generic OHCI platform driver.
>
> And likewise for the SSB EHCI driver, of course.
That sounds good, I will change that.
Hauke
next prev parent reply other threads:[~2012-03-12 20:51 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-11 20:08 [PATCH 0/7] USB: OHCI/EHCI: generic platform driver Hauke Mehrtens
2012-03-11 20:08 ` [PATCH 1/7] USB: OHCI: Add a generic platform device driver Hauke Mehrtens
2012-03-11 20:08 ` [PATCH 2/7] USB: EHCI: " Hauke Mehrtens
2012-03-11 20:08 ` [PATCH 3/7] bcma: scan for extra address space Hauke Mehrtens
2012-03-11 21:59 ` Julian Calaby
2012-03-11 23:34 ` Hauke Mehrtens
2012-03-12 1:30 ` Julian Calaby
2012-03-12 17:41 ` John W. Linville
2012-03-12 17:58 ` Florian Fainelli
2012-03-12 20:47 ` Hauke Mehrtens
2012-03-11 20:08 ` [PATCH 4/7] USB: Add driver for the bcma bus Hauke Mehrtens
2012-03-11 20:08 ` [PATCH 5/7] USB: Add driver for the ssb bus Hauke Mehrtens
2012-03-11 20:08 ` [PATCH 6/7] USB: OHCI: remove old SSB OHCI driver Hauke Mehrtens
2012-03-12 14:28 ` Alan Stern
2012-03-12 14:28 ` Alan Stern
2012-03-12 20:50 ` Hauke Mehrtens [this message]
2012-03-11 20:08 ` [PATCH 7/7] USB: use generic platform driver on ath79 Hauke Mehrtens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F5E61A8.20903@hauke-m.de \
--to=hauke@hauke-m.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-usb@vger.kernel.org \
--cc=m@bues.ch \
--cc=ralf@linux-mips.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox