From: Sergei Shtylyov <sshtylyov@mvista.com>
To: Paul Gortmaker <paul.gortmaker@gmail.com>
Cc: klassert@mathematik.tu-chemnitz.de, netdev@vger.kernel.org,
linux-mips@linux-mips.org,
Paul Gortmaker <paul.gortmaker@windriver.com>
Subject: Re: [PATCH] netdev: fix compile issues for !CONFIG_PCI in 3c59x
Date: Mon, 26 Mar 2012 18:55:10 +0400 [thread overview]
Message-ID: <4F70834E.3000308@mvista.com> (raw)
In-Reply-To: <CAP=VYLpOJOueFfzxFGCu5cKQ9--F8CqC5JWjBxej7u=8z3K0xQ@mail.gmail.com>
Hello.
On 03/26/2012 05:38 PM, Paul Gortmaker wrote:
>> I hate to add in more #ifdef CONFIG_PCI but there are already
>> quite a few in this driver, and it seems like it hasn't been
>> built with CONFIG_PCI set to off in quite some time.
> Actually, please scrap this patch. The uglyness of more ifdefs
> made me look at it again. It should be do-able in a cleaner way
> with stubs, and it appears this may even be similar to an old fail
> from the past:
> http://lkml.indiana.edu/hypermail/linux/kernel/1107.3/00109.html
Also, see this patch:
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=0da0ead90122578ef6e4afba9ba4bcd3455fd8e8
The driver patch this was done for is still in the -mm tree after all these
years.:-)
> I'll dig into it some more and follow up.
I thought I addressed all issues with compilation of this driver with
CONFIG_PCI=n. Apparently not, and some seem to have accumulated over time...
> Thanks,
> Paul.
WBR, Sergei
next prev parent reply other threads:[~2012-03-26 14:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-26 1:11 [PATCH] netdev: fix compile issues for !CONFIG_PCI in 3c59x Paul Gortmaker
2012-03-26 13:38 ` Paul Gortmaker
2012-03-26 14:55 ` Sergei Shtylyov [this message]
2012-03-26 15:38 ` Paul Gortmaker
2012-03-26 15:38 ` Paul Gortmaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F70834E.3000308@mvista.com \
--to=sshtylyov@mvista.com \
--cc=klassert@mathematik.tu-chemnitz.de \
--cc=linux-mips@linux-mips.org \
--cc=netdev@vger.kernel.org \
--cc=paul.gortmaker@gmail.com \
--cc=paul.gortmaker@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox