Linux MIPS Architecture development
 help / color / mirror / Atom feed
From: John Stultz <john.stultz@linaro.org>
To: Ralf Baechle <ralf@linux-mips.org>
Cc: Yong Zhang <yong.zhang0@gmail.com>, linux-mips@linux-mips.org
Subject: pnx_clocksource broken?
Date: Tue, 10 Apr 2012 18:58:09 -0700	[thread overview]
Message-ID: <4F84E531.3010001@linaro.org> (raw)

Looking at arch/mips/pnx8550/common/time.c the pnx_clocksource never 
seems to be assigned a mult/shift value before it calls 
clocksource_register(). Clearly this is broken and I suspect this 
clocksource is never used.

I was hoping to convert this driver over (its the last of 3 remaining) 
to use clocksource_register_hz/khz() but I'm not sure what the actual 
frequency of the hardware should be. Is mips_hpt_frequency the right 
value here?

Even so, if this is clocksource is never used, should it just be removed?

thanks
-john

             reply	other threads:[~2012-04-11  1:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-11  1:58 John Stultz [this message]
2012-04-16 14:00 ` Any NXP PNX user left (was: Re: pnx_clocksource broken?) Ralf Baechle
2013-01-22 11:54   ` Ralf Baechle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F84E531.3010001@linaro.org \
    --to=john.stultz@linaro.org \
    --cc=linux-mips@linux-mips.org \
    --cc=ralf@linux-mips.org \
    --cc=yong.zhang0@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox