From: David Daney <ddaney.cavm@gmail.com>
To: Hillf Danton <dhillf@gmail.com>
Cc: Ralf Baechle <ralf@linux-mips.org>,
Andrea Arcangeli <aarcange@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mips@linux-mips.org
Subject: Re: [PATCH 2/3] MIPS: changes in mm for adding THP
Date: Tue, 24 Apr 2012 16:31:37 -0700 [thread overview]
Message-ID: <4F9737D9.9080008@gmail.com> (raw)
In-Reply-To: <CAJd=RBBWia26FaPjn5-RvmAy9MBRtF0Bthkc0f7kxEWcFz6=oQ@mail.gmail.com>
On 11/26/2011 06:39 AM, Hillf Danton wrote:
> Based on the current work of huge TLB, no code is added for THP but info gcc
> to compile the huge TLB code for THP. That is the second factor why the present
> bit is selected.
>
> Signed-off-by: Hillf Danton<dhillf@gmail.com>
> ---
>
> --- a/arch/mips/include/asm/page.h Thu Nov 24 21:17:10 2011
> +++ b/arch/mips/include/asm/page.h Sat Nov 26 21:35:51 2011
> @@ -33,7 +33,7 @@
> #define PAGE_SIZE (_AC(1,UL)<< PAGE_SHIFT)
> #define PAGE_MASK (~((1<< PAGE_SHIFT) - 1))
>
> -#ifdef CONFIG_HUGETLB_PAGE
> +#if defined(CONFIG_HUGETLB_PAGE) || defined(CONFIG_TRANSPARENT_HUGEPAGE)
This exact sequence happens many times in the patch.
Can we define some symbol (perhaps in page.h) that is set for both of
the conditions?
#if defined(CONFIG_HUGETLB_PAGE) || defined(CONFIG_TRANSPARENT_HUGEPAGE)
#define BRFL
#endif
.
.
.
#ifdef BRFL /* everywhere else */
We of course wouldn't use the name BRFL, but rather something fitting.
With a change like that, I would like to retest the patches and try to
get them merged.
David Daney
next prev parent reply other threads:[~2012-04-24 23:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-26 14:39 [PATCH 2/3] MIPS: changes in mm for adding THP Hillf Danton
2012-04-24 23:31 ` David Daney [this message]
2012-04-25 13:51 ` Hillf Danton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F9737D9.9080008@gmail.com \
--to=ddaney.cavm@gmail.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=dhillf@gmail.com \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox