Linux MIPS Architecture development
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sshtylyov@mvista.com>
To: "Steven J. Hill" <sjhill@mips.com>
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org,
	Leonid Yegoshin <yegoshin@mips.com>
Subject: Re: [PATCH v3] Revert fixrange_init() limiting to the FIXMAP region.
Date: Fri, 11 May 2012 21:19:24 +0400	[thread overview]
Message-ID: <4FAD4A1C.70307@mvista.com> (raw)
In-Reply-To: <1336755231-5678-1-git-send-email-sjhill@mips.com>

Hello.

On 05/11/2012 08:53 PM, Steven J. Hill wrote:

> From: "Steven J. Hill"<sjhill@mips.com>

> This patch refactors 464fd83e841a16f4ea1325b33eb08170ef5cd1f4 and

   Please also specify that commit's summary in parens.

> correctly calculates the right length while taking into account
> page table alignment by PMD.

> Signed-off-by: Leonid Yegoshin<yegoshin@mips.com>
> Signed-off-by: Steven J. Hill<sjhill@mips.com>
[...]

> diff --git a/arch/mips/mm/pgtable-32.c b/arch/mips/mm/pgtable-32.c
> index adc6911..5d27baf 100644
> --- a/arch/mips/mm/pgtable-32.c
> +++ b/arch/mips/mm/pgtable-32.c
[...]
> @@ -51,8 +52,11 @@ void __init pagetable_init(void)
>   	/*
>   	 * Fixed mappings:
>   	 */
> -	vaddr = __fix_to_virt(__end_of_fixed_addresses - 1)&  PMD_MASK;
> -	fixrange_init(vaddr, vaddr + FIXADDR_SIZE, pgd_base);
> +	vaddr = __fix_to_virt(__end_of_fixed_addresses - 1);
> +	/* Calculate real end before alignment. */
> +	vend = vaddr + FIXADDR_SIZE;
> +	vaddr = vaddr & PMD_MASK;

	vaddr &= PMD_MASK;

WBR, Sergei

      reply	other threads:[~2012-05-11 17:20 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-11 16:53 [PATCH v3] Revert fixrange_init() limiting to the FIXMAP region Steven J. Hill
2012-05-11 17:19 ` Sergei Shtylyov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FAD4A1C.70307@mvista.com \
    --to=sshtylyov@mvista.com \
    --cc=linux-mips@linux-mips.org \
    --cc=ralf@linux-mips.org \
    --cc=sjhill@mips.com \
    --cc=yegoshin@mips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox