From: Sergei Shtylyov <sshtylyov@mvista.com>
To: "Yegoshin, Leonid" <yegoshin@mips.com>
Cc: "Hill, Steven" <sjhill@mips.com>,
"linux-mips@linux-mips.org" <linux-mips@linux-mips.org>,
"ralf@linux-mips.org" <ralf@linux-mips.org>
Subject: Re: [PATCH v2] Add MIPS64R2 core support.
Date: Fri, 11 May 2012 22:05:29 +0400 [thread overview]
Message-ID: <4FAD54E9.6030102@mvista.com> (raw)
In-Reply-To: <j9ltxtmuep0qhf4mgqhj4du5.1336758301121@email.android.com>
Hello.
On 05/11/2012 09:45 PM, Yegoshin, Leonid wrote:
> I don't see any advantage in separation of it.
I do. And I certainly do see an advantage of bothering to describe your
changes, not just throwing in patch with unclear summary, no changelog at all,
doing 3 things at once and then hoping for it to be silently accepted.
> Sergei Shtylyov<sshtylyov@mvista.com> wrote:
> Hello.
> On 05/11/2012 09:32 PM, Yegoshin, Leonid wrote:
>> Not exactly - it adds 64R2 support in Malta, plus small verification that build kernel could run 32bit binaries.
>> I don't think it has sense to multiply patches here, there is no sense to have this separated.
>> 5KEc is just test-bed.
> Well, rule of thumb is do one thing per patch. You do three. All that
> without proper description.
PS: Please stop top-posting.
WBR, Sergei
next prev parent reply other threads:[~2012-05-11 18:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-11 6:29 [PATCH v2] Add MIPS64R2 core support Steven J. Hill
2012-05-11 17:25 ` Sergei Shtylyov
2012-05-11 17:32 ` Yegoshin, Leonid
2012-05-11 17:37 ` Sergei Shtylyov
2012-05-11 17:45 ` Yegoshin, Leonid
2012-05-11 18:05 ` Sergei Shtylyov [this message]
2012-05-11 18:23 ` Hill, Steven
2012-05-11 18:36 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FAD54E9.6030102@mvista.com \
--to=sshtylyov@mvista.com \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=sjhill@mips.com \
--cc=yegoshin@mips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox