Linux MIPS Architecture development
 help / color / mirror / Atom feed
From: John Crispin <john@phrozen.org>
To: Deng-Cheng Zhu <dczhu@mips.com>
Cc: linux-mips@linux-mips.org, kevink@paralogos.com
Subject: Re: [PATCH v2 1/2] MIPS: fix/enrich 34K APRP (APSP) functionalities
Date: Thu, 17 May 2012 14:30:57 +0200	[thread overview]
Message-ID: <4FB4EF81.10005@phrozen.org> (raw)
In-Reply-To: <1337244680-29968-2-git-send-email-dczhu@mips.com>

Hi,

> diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
> index ce30e2f..8205afe 100644
> --- a/arch/mips/Kconfig
> +++ b/arch/mips/Kconfig
> @@ -1925,7 +1925,7 @@ config MIPS_MT_FPAFF
>  
>  config MIPS_VPE_LOADER
>  	bool "VPE loader support."
> -	depends on SYS_SUPPORTS_MULTITHREADING
> +	depends on SYS_SUPPORTS_MULTITHREADING && MIPS_MALTA

This would lead to the second user of the API having to patch this piece
of code to make it work.

You could introduce a ARCH_HAS_APRP which any platform can then select ?

I think it would also make sense to split changes to generic and malta
code into separate patches if that is possible.

Thanks,
John

  parent reply	other threads:[~2012-05-17 12:31 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-17  8:51 [PATCH v2 0/2] MIPS: enable APRP (APSP) and add features - v2 Deng-Cheng Zhu
2012-05-17  8:51 ` Deng-Cheng Zhu
2012-05-17  8:51 ` [PATCH v2 1/2] MIPS: fix/enrich 34K APRP (APSP) functionalities Deng-Cheng Zhu
2012-05-17  8:51   ` Deng-Cheng Zhu
2012-05-17 12:30   ` John Crispin [this message]
2012-05-18  8:10     ` Deng-Cheng Zhu
2012-05-18  8:10       ` Deng-Cheng Zhu
2012-05-18 18:06       ` John Crispin
2012-05-20 21:32         ` Maciej W. Rozycki
2012-05-21  3:23           ` Deng-Cheng Zhu
2012-05-21  3:23             ` Deng-Cheng Zhu
2012-05-21 23:17             ` Maciej W. Rozycki
2012-05-22  7:05               ` Deng-Cheng Zhu
2012-05-22  7:05                 ` Deng-Cheng Zhu
2012-05-22 22:12                 ` Maciej W. Rozycki
2012-05-23  9:07                   ` Deng-Cheng Zhu
2012-05-23  9:07                     ` Deng-Cheng Zhu
2012-05-17  8:51 ` [PATCH v2 2/2] MIPS: enable CPS multicore APRP (APSP) Deng-Cheng Zhu
2012-05-17  8:51   ` Deng-Cheng Zhu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FB4EF81.10005@phrozen.org \
    --to=john@phrozen.org \
    --cc=dczhu@mips.com \
    --cc=kevink@paralogos.com \
    --cc=linux-mips@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox