From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Tue, 22 May 2012 21:45:23 +0200 (CEST) Received: from mail-pb0-f49.google.com ([209.85.160.49]:35491 "EHLO mail-pb0-f49.google.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S1903711Ab2EVTpQ (ORCPT ); Tue, 22 May 2012 21:45:16 +0200 Received: by pbbrq13 with SMTP id rq13so9976052pbb.36 for ; Tue, 22 May 2012 12:45:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=KTrTL2CZ6lhaat+cdME0wbTrhKL0Yv+yUNN/Gyj6jrI=; b=dmsIMVlUPBZaVtMKK+dCSj0uPw4N4PCGJACLi49FqtRX+jtEZ0XJHEjRGLHOUYadT+ ZVfl7U2pi2E8dSiDptLZ5PHSjO7A0YfE4AQIxAFR3A0eTAUK1E807zVxyNIfnfdM8+Ri xYVG8F8cVHkThC5depI3KKInkzApU+OAS3Z+3fg8DaeMeXXk419768JAfEilPIXIvinc NCCbJGY88/Lwr6R9vzXtH26B4yaWuEeSr4N8omHPSchTr255VFERcpOtT5JazFy3A9Jd VOqzqOiHT6KODyyvykFhbOob9/ulQmj3xPr+Aj5JuBEPOR7S/c1gtJudE9CiAtqHpgG1 KMug== Received: by 10.68.229.65 with SMTP id so1mr2220425pbc.2.1337715910108; Tue, 22 May 2012 12:45:10 -0700 (PDT) Received: from dd1.caveonetworks.com (64.2.3.195.ptr.us.xo.net. [64.2.3.195]) by mx.google.com with ESMTPS id tx3sm27668139pbc.2.2012.05.22.12.45.07 (version=SSLv3 cipher=OTHER); Tue, 22 May 2012 12:45:08 -0700 (PDT) Message-ID: <4FBBECC2.10503@gmail.com> Date: Tue, 22 May 2012 12:45:06 -0700 From: David Daney User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.15) Gecko/20101027 Fedora/3.0.10-1.fc12 Thunderbird/3.0.10 MIME-Version: 1.0 To: Grant Likely CC: David Daney , "devicetree-discuss@lists.ozlabs.org" , Rob Herring , "spi-devel-general@lists.sourceforge.net" , "linux-kernel@vger.kernel.org" , "linux-mips@linux-mips.org" , "linux-doc@vger.kernel.org" , Liam Girdwood , Tabi Timur-B04825 , Mark Brown , Jaroslav Kysela , Takashi Iwai , "alsa-devel@alsa-project.org" , "linuxppc-dev@lists.ozlabs.org" Subject: Re: [PATCH 1/3] of: Add prefix parameter to of_modalias_node(). References: <1336773923-17866-1-git-send-email-ddaney.cavm@gmail.com> <1336773923-17866-2-git-send-email-ddaney.cavm@gmail.com> <20120520055436.13AF03E03B8@localhost> <20120520060802.03CE73E03B8@localhost> In-Reply-To: <20120520060802.03CE73E03B8@localhost> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-archive-position: 33427 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: ddaney.cavm@gmail.com Precedence: bulk X-list: linux-mips Return-Path: On 05/19/2012 11:08 PM, Grant Likely wrote: > On Sat, 19 May 2012 23:54:36 -0600, Grant Likely wrote: >> On Fri, 11 May 2012 15:05:21 -0700, David Daney wrote: >>> From: David Daney >>> >>> When generating MODALIASes, it is convenient to add things like "spi:" >>> or "i2c:" to the front of the strings. This allows the standard >>> modprobe to find the right driver when automatically populating bus >>> children from the device tree structure. >>> >>> Add a prefix parameter, and adjust callers. For >>> of_register_spi_devices() use the "spi:" prefix. >>> >>> Signed-off-by: David Daney >> >> Applied, thanks. Some notes below... > > Wait... why is this necessary? Because in of_register_spi_devices() in of_spi.c, you do: request_module(spi->modalias); The string passed to request_module() must have the "spi:" prefix. > The module type prefix isn't stored in > the modalias value for any other bus type as far as I can see, It is only useful with the prefix, so I though I would add it to the stored value. > and > with this series it appears that the "spi:" prefix may or may not be > present in the modalias. That doesn't look right. Perhaps, but the with the combination of patches 1/3 and 2/3 I tried to ensure that the prefix would always be present for SPI devices. > > Why isn't prefixing spi: at uevent time sufficient? Because udev may not be loading the driver. > IIUC, modprobe > depends on either UEVENT or the modalias attribute to know which > driver to probe. It does look like the attribute is missing the spi: > prefix though. Does the following change work instead of these two > patches? > No. > diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c > index 3d8f662..da8aac7 100644 > --- a/drivers/spi/spi.c > +++ b/drivers/spi/spi.c > @@ -51,7 +51,7 @@ modalias_show(struct device *dev, struct device_attribute *a, char *buf) > { > const struct spi_device *spi = to_spi_device(dev); > > - return sprintf(buf, "%s\n", spi->modalias); > + return sprintf(buf, "%s%s\n", SPI_MODULE_PREFIX, spi->modalias); > } > > So, I've dropped this patch from my tree. If the change above works > for you then I'll push it out. > > g. > From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pb0-f49.google.com ([209.85.160.49]:35491 "EHLO mail-pb0-f49.google.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S1903711Ab2EVTpQ (ORCPT ); Tue, 22 May 2012 21:45:16 +0200 Received: by pbbrq13 with SMTP id rq13so9976052pbb.36 for ; Tue, 22 May 2012 12:45:10 -0700 (PDT) Message-ID: <4FBBECC2.10503@gmail.com> Date: Tue, 22 May 2012 12:45:06 -0700 From: David Daney MIME-Version: 1.0 Subject: Re: [PATCH 1/3] of: Add prefix parameter to of_modalias_node(). References: <1336773923-17866-1-git-send-email-ddaney.cavm@gmail.com> <1336773923-17866-2-git-send-email-ddaney.cavm@gmail.com> <20120520055436.13AF03E03B8@localhost> <20120520060802.03CE73E03B8@localhost> In-Reply-To: <20120520060802.03CE73E03B8@localhost> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org Return-Path: To: Grant Likely Cc: David Daney , "devicetree-discuss@lists.ozlabs.org" , Rob Herring , "spi-devel-general@lists.sourceforge.net" , "linux-kernel@vger.kernel.org" , "linux-mips@linux-mips.org" , "linux-doc@vger.kernel.org" , Liam Girdwood , Tabi Timur-B04825 , Mark Brown , Jaroslav Kysela , Takashi Iwai , "alsa-devel@alsa-project.org" , "linuxppc-dev@lists.ozlabs.org" Message-ID: <20120522194506.FnVusd6yhRAgpCUKukEBIWmwvPjEAwk-bjJB9LFV31s@z> On 05/19/2012 11:08 PM, Grant Likely wrote: > On Sat, 19 May 2012 23:54:36 -0600, Grant Likely wrote: >> On Fri, 11 May 2012 15:05:21 -0700, David Daney wrote: >>> From: David Daney >>> >>> When generating MODALIASes, it is convenient to add things like "spi:" >>> or "i2c:" to the front of the strings. This allows the standard >>> modprobe to find the right driver when automatically populating bus >>> children from the device tree structure. >>> >>> Add a prefix parameter, and adjust callers. For >>> of_register_spi_devices() use the "spi:" prefix. >>> >>> Signed-off-by: David Daney >> >> Applied, thanks. Some notes below... > > Wait... why is this necessary? Because in of_register_spi_devices() in of_spi.c, you do: request_module(spi->modalias); The string passed to request_module() must have the "spi:" prefix. > The module type prefix isn't stored in > the modalias value for any other bus type as far as I can see, It is only useful with the prefix, so I though I would add it to the stored value. > and > with this series it appears that the "spi:" prefix may or may not be > present in the modalias. That doesn't look right. Perhaps, but the with the combination of patches 1/3 and 2/3 I tried to ensure that the prefix would always be present for SPI devices. > > Why isn't prefixing spi: at uevent time sufficient? Because udev may not be loading the driver. > IIUC, modprobe > depends on either UEVENT or the modalias attribute to know which > driver to probe. It does look like the attribute is missing the spi: > prefix though. Does the following change work instead of these two > patches? > No. > diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c > index 3d8f662..da8aac7 100644 > --- a/drivers/spi/spi.c > +++ b/drivers/spi/spi.c > @@ -51,7 +51,7 @@ modalias_show(struct device *dev, struct device_attribute *a, char *buf) > { > const struct spi_device *spi = to_spi_device(dev); > > - return sprintf(buf, "%s\n", spi->modalias); > + return sprintf(buf, "%s%s\n", SPI_MODULE_PREFIX, spi->modalias); > } > > So, I've dropped this patch from my tree. If the change above works > for you then I'll push it out. > > g. >