From: David Daney <david.daney@cavium.com>
To: "Steven J. Hill" <sjhill@mips.com>, ralf@linux-mips.org
Cc: linux-mips@linux-mips.org
Subject: Re: [PATCH] MIPS: Refactor 'clear_page' and 'copy_page' functions.
Date: Wed, 30 May 2012 11:10:23 -0700 [thread overview]
Message-ID: <4FC6628F.9060807@cavium.com> (raw)
In-Reply-To: <1337891904-24093-1-git-send-email-sjhill@mips.com>
On 05/24/2012 01:38 PM, Steven J. Hill wrote:
> From: "Steven J. Hill"<sjhill@mips.com>
>
> Remove usage of the '__attribute__((alias("...")))' hack that aliased
> to integer arrays containing micro-assembled instructions. This hack
> breaks when building a microMIPS kernel. It also makes the code much
> easier to understand.
>
> Signed-off-by: Steven J. Hill<sjhill@mips.com>
Looks good to (and even works for) me:
Acked-by: David Daney <david.daney@cavium.com>
> ---
> arch/mips/mm/Makefile | 4 +--
> arch/mips/mm/page-funcs.S | 49 +++++++++++++++++++++++++++++++++
> arch/mips/mm/page.c | 67 ++++++++++++---------------------------------
> 3 files changed, 69 insertions(+), 51 deletions(-)
> create mode 100644 arch/mips/mm/page-funcs.S
>
next prev parent reply other threads:[~2012-05-30 18:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-24 20:38 [PATCH] MIPS: Refactor 'clear_page' and 'copy_page' functions Steven J. Hill
2012-05-30 18:10 ` David Daney [this message]
2012-05-30 21:01 ` Ralf Baechle
2012-05-30 21:27 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FC6628F.9060807@cavium.com \
--to=david.daney@cavium.com \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=sjhill@mips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox