Re: [PATCH 07/35] MIPS: ath79: Cleanup files effected by firmware changes.

[Sergei Shtylyov <sshtylyov@mvista.com>]

Hello.

On 06-06-2012 1:19, Steven J. Hill wrote:

> From: "Steven J. Hill"<sjhill@mips.com>

> Make headers consistent across the files and make changes based on
> running the checkpatch script.

> Signed-off-by: Steven J. Hill<sjhill@mips.com>
> ---
>   arch/mips/ath79/prom.c |   13 +++++--------
>   1 file changed, 5 insertions(+), 8 deletions(-)
>
> diff --git a/arch/mips/ath79/prom.c b/arch/mips/ath79/prom.c
> index adbe614..9ead18a 100644
> --- a/arch/mips/ath79/prom.c
> +++ b/arch/mips/ath79/prom.c
> @@ -1,18 +1,15 @@
>   /*
> + * This file is subject to the terms and conditions of the GNU General Public
> + * License.  See the file "COPYING" in the main directory of this archive
> + * for more details.
> + *

    Why move/change this text at all?

>    *  Atheros AR71XX/AR724X/AR913X specific prom routines
>    *
>    *  Copyright (C) 2008-2010 Gabor Juhos<juhosg@openwrt.org>
>    *  Copyright (C) 2008 Imre Kaloz<kaloz@openwrt.org>
> - *
> - *  This program is free software; you can redistribute it and/or modify it
> - *  under the terms of the GNU General Public License version 2 as published
> - *  by the Free Software Foundation.
> + *  Copyright (C) 2012 MIPS Technologies, Inc.  All rights reserved.
>    */
> -
> -#include<linux/kernel.h>
> -#include<linux/init.h>
>   #include<linux/io.h>
> -#include<linux/string.h>

    Removing a few #include's doesn't justify copyrighting the file. You 
generally need to do some substantial change (some people say about 1/3) to 
the file to claim the copyright.

WBR, Sergei