From: David Daney <ddaney.cavm@gmail.com>
To: Shane McDonald <mcdonald.shane@gmail.com>
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org
Subject: Re: [PATCH v2 5/5] MIPS: Move cache setup to setup_arch().
Date: Mon, 11 Jun 2012 09:39:17 -0700 [thread overview]
Message-ID: <4FD61F35.1080103@gmail.com> (raw)
In-Reply-To: <4FD61B22.3040407@gmail.com>
On 06/11/2012 09:21 AM, David Daney wrote:
> On 06/10/2012 09:16 PM, Shane McDonald wrote:
>> I've run into a problem in linux-3.5-rc1, and I've tracked it down
>> to this patch, MIPS: Move cache setup to setup_arch().,
>> commit 6650df3c380e0db558dbfec63ed860402c6afb2a.
>>
>
> Are you permitted to describe the problem in any additional detail?
>
> Knowing what type of system is affected and the nature of the problem
> would be useful in trying to arrive at a good solution.
>
OK, for some reason I missed this bit...
[...]
>>
>> I'm running a single-CPU, PMC-Sierra RM7035C-based system.
>>
>> Before applying this patch, cca_setup() in arch/mips/mm/c-r4k.c
>> is called before coherency_setup() (called from rk4_cache_init()).
>> After applying the patch, it is called afterwards. Because
>> coherency_setup() relies on cca_setup() properly setting the
>> variable cca, it won't use the value of cca supplied on the
>> kernel command line.
>>
>> I haven't verified it, but I suspect the same problem will occur
>> with the call to setcoherentio(), also in c-r4k.c.
>>
>> Unfortunately, I don't have the knowledge to formulate a patch
>> to this problem, but I wanted to raise the issue.
>>
>> Shane McDonald
>>
>
I will think about how to fix it.
David Daney
next prev parent reply other threads:[~2012-06-11 16:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-15 0:04 [PATCH v2 0/5] MIPS: Move cache setup earlier David Daney
2012-05-15 0:04 ` David Daney
2012-05-15 0:04 ` [PATCH v2 1/5] MIPS: Introduce board_cache_error_setup() hook David Daney
2012-05-15 0:04 ` [PATCH v2 2/5] MIPS: Make set_handler() __cpuinit David Daney
2012-05-15 11:10 ` Sergei Shtylyov
2012-05-15 0:04 ` [PATCH v2 3/5] MIPS: Octeon: Use board_cache_error_setup for cache error handler setup David Daney
2012-05-15 0:04 ` [PATCH v2 4/5] MIPS: Use board_cache_error_setup for r4k " David Daney
2012-05-15 0:04 ` [PATCH v2 5/5] MIPS: Move cache setup to setup_arch() David Daney
2012-06-11 4:16 ` Shane McDonald
2012-06-11 16:21 ` David Daney
2012-06-11 16:39 ` David Daney [this message]
2012-06-11 18:32 ` Shane McDonald
2012-06-13 15:44 ` Shane McDonald
2012-06-13 16:29 ` David Daney
2012-06-13 17:08 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FD61F35.1080103@gmail.com \
--to=ddaney.cavm@gmail.com \
--cc=linux-mips@linux-mips.org \
--cc=mcdonald.shane@gmail.com \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox