From: Paul Cercueil <paul@crapouillou.net>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Artur Rojek <contact@artur-rojek.eu>,
Jonathan Cameron <jic23@kernel.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Chris Morgan <macromorgan@hotmail.com>,
BROADCOM NVRAM DRIVER <linux-mips@vger.kernel.org>,
linux-iio <linux-iio@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-input <linux-input@vger.kernel.org>
Subject: Re: [PATCH 1/4] iio/adc: ingenic: fix channel offsets in buffer
Date: Fri, 19 Aug 2022 12:07:16 +0200 [thread overview]
Message-ID: <4GXUGR.SAF00K92YJMF@crapouillou.net> (raw)
In-Reply-To: <CAHp75Vd49aCKkK+KvmxJrW2mKk7=VgtSBCTYE9umOhZhc4Y8FA@mail.gmail.com>
Hi Andy,
Le ven., août 19 2022 at 11:12:38 +0300, Andy Shevchenko
<andy.shevchenko@gmail.com> a écrit :
> On Wed, Aug 17, 2022 at 1:58 PM Artur Rojek <contact@artur-rojek.eu>
> wrote:
>>
>> Consumers expect the buffer to only contain enabled channels. While
>> preparing the buffer, the driver also (incorrectly) inserts empty
>> data
>> for disabled channels, causing the enabled channels to appear at
>> wrong
>> offsets. Fix that.
>
> What consumers? Have you tested on all of them? Please, elaborate. It
> might be that some of them have to be fixed. In such case you need to
> report the issue to their respective channels and put the
> corresponding links here.
There are no consumers to fix, only this driver. I believe it wasn't
noticed until now because all consumers were only using channels 0 and
1.
Cheers,
-Paul
> P.S. It doesn't mean I'm against the patch.
>
> --
> With Best Regards,
> Andy Shevchenko
next prev parent reply other threads:[~2022-08-19 10:07 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-17 10:56 [PATCH 0/4] iio/adc-joystick: buffer data parsing fixes Artur Rojek
2022-08-17 10:56 ` [PATCH 1/4] iio/adc: ingenic: fix channel offsets in buffer Artur Rojek
2022-08-19 8:12 ` Andy Shevchenko
2022-08-19 10:07 ` Paul Cercueil [this message]
2022-08-19 10:15 ` Andy Shevchenko
2022-08-17 10:56 ` [PATCH 2/4] iio: add iio_channel_cb_get_iio_buffer helper Artur Rojek
2022-08-19 8:14 ` Andy Shevchenko
2022-08-19 17:35 ` Jonathan Cameron
2022-08-19 17:44 ` Jonathan Cameron
2022-08-17 10:56 ` [PATCH 3/4] iio: add helper function for reading channel offset in buffer Artur Rojek
2022-08-19 8:17 ` Andy Shevchenko
2022-08-19 10:33 ` Artur Rojek
2022-08-19 10:36 ` Andy Shevchenko
2022-08-19 17:49 ` Jonathan Cameron
2022-08-17 10:56 ` [PATCH 4/4] input: joystick: Fix buffer data parsing Artur Rojek
2022-08-19 8:21 ` Andy Shevchenko
2022-08-19 17:53 ` Jonathan Cameron
2022-08-22 9:03 ` Paul Cercueil
2022-08-22 19:01 ` Jonathan Cameron
2022-08-18 18:28 ` [PATCH 0/4] iio/adc-joystick: buffer data parsing fixes Chris Morgan
2022-08-19 10:36 ` Artur Rojek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4GXUGR.SAF00K92YJMF@crapouillou.net \
--to=paul@crapouillou.net \
--cc=andy.shevchenko@gmail.com \
--cc=contact@artur-rojek.eu \
--cc=dmitry.torokhov@gmail.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=macromorgan@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox